search

GoogleCloudPlatform / spring-cloud-gcp

New home for Spring Cloud GCP development starting with version 2.0.
Apache License 2.0
425 stars 316 forks source link

Add Cloud DLP integration with auto configuration and starter support #699

Open mvpzone opened 3 years ago

mvpzone commented 3 years ago

Proposed feature request related to an enhancement. Spring Cloud GCP currently does not have native auto-configuration and starter integration with GCP DLP. Cloud DLP offers java API & client libraries.

Description of the problem Use of DLP with spring boot is not to the same levels as other apis e.g. Cloud Vision.

Describe the proposed solution This enhancement is to propose additional support for Cloud DLP similar to other cloud api's. A prototype implementation has been made available in the following GitHub repo.

Describe alternatives you've considered Alternatives to the native spring boot integration involve the direct use of the DLP Java API (with no auto configure / starter support). The alternative increases bootstrapping effort in code.

Additional context The prototype implementation does not take into account imminent InfoType versioning support. The final contributions will be enhanced to the new API surface (InfoType versioning).

mvpzone commented 3 years ago

The initial contribution and validation is happening on this repo. When the info type versioning makes it to the API surface a PR will be submitted.

dzou commented 3 years ago

Thank you for your contribution. We're still in the process of discussing this internally regarding how to contribute and maintain this module; I will share any updates as they come.

elefeint commented 2 years ago

@mvpzone I apologize for the delay. I've reviewed the code in your repo, and the approach looks good to me. It would be good to have a sample application, too, but that can be done as a follow-up. Could you create a pull request in this repository, so we can work out the specifics?

mvpzone commented 2 years ago

@elefeint Will get started on the PR and will look to include a sample app too (so we have a usage example right from the get go.). I am debating if we should also wait to include the DLP InfoType versioning to make it into the API surface or not prior to the PR?

elefeint commented 2 years ago

@mvpzone Yes, let's wait for the API surface to be stable.

elefeint commented 2 years ago

@zhumin8 Take a look at https://github.com/mvpzone/spring-cloud-gcp-dlp -- see if this is something that would fit in well with your autoconfig generator.