search

GoogleCloudPlatform / tensorflow-without-a-phd

A crash course in six episodes for software developers who want to become machine learning practitioners.
Apache License 2.0
2.79k stars 911 forks source link

Update the rl-pong example for tf 1.10 #26

Closed dizcology closed 6 years ago

dizcology commented 6 years ago

There was a compatibility issue from TensorFlow 1.8 to 1.9, where the variable reuse behavior was changed when building a model with Keras.

Related issue: https://github.com/GoogleCloudPlatform/tensorflow-without-a-phd/issues/20 (Possibly related issue: https://github.com/GoogleCloudPlatform/tensorflow-without-a-phd/issues/11)

martin-gorner commented 6 years ago

Thanks you for the fix. Did you test by training again and are you sure that this new model does not require a new "demo checkpoint" in the "demo-checkpoint" folder ?

dizcology commented 6 years ago

retrained and replaced demo-checkpoint.

martin-gorner commented 6 years ago

Thanks, merging