GoogleCloudPlatform / testgrid

Apache License 2.0
198 stars 68 forks source link

Specify auto-project detection for PubSub. #1289

Closed michelle192837 closed 2 months ago

michelle192837 commented 2 months ago

In pubsub v1.32, a breaking change made it so specifying a blank project results in an error, rather than automatically detecting the project as it did before. Instead, specify the sentinel value for detecting the project automatically.

See https://github.com/googleapis/google-cloud-go/releases/tag/pubsub%2Fv1.32.0.

Note that an update a while back upgraded the pubsub module version from v1.22.2 to v1.33.0.

Verified locally that this change fixes some startup failures that exist on the current images. (This should be fixed the next time images are built and the autobump includes them in configs).

michelle192837 commented 2 months ago

/hold

One moment, updating tabulator and summarizer as well

simony-gke commented 2 months ago

/lgtm

google-oss-prow[bot] commented 2 months ago

@simony-gke: changing LGTM is restricted to collaborators

In response to [this](https://github.com/GoogleCloudPlatform/testgrid/pull/1289#issuecomment-2354075715): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
michelle192837 commented 2 months ago

/hold cancel

Updated all three files and verified that they work with the change.

google-oss-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chases2, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/GoogleCloudPlatform/testgrid/blob/main/OWNERS)~~ [chases2,michelle192837] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment