search

GoogleCloudPlatform / traffic-director-grpc-examples

Apache License 2.0
21 stars 22 forks source link

Fix java build after version bumped to 1.40 #62

Closed dapengzhang0 closed 3 years ago

dapengzhang0 commented 3 years ago

After version bumped to 1.40, the client side trace span exported is the Attempt span with a parent, and the test need be updated accordingly.

ejona86 commented 3 years ago

Why is the server updated then?

dapengzhang0 commented 3 years ago

Why is the server updated then?

We can no longer identify a server by parent id being not null. The criteria is server span name is "Recv.serviceName.methodName" and client span name is "Attempt.serviceName.methodName".

ejona86 commented 3 years ago

We can no longer identify a server by parent id being not null.

Oh, because the client will also have it non-null. kk