search

GoogleContainerTools / rules_distroless

Apache License 2.0
55 stars 34 forks source link

fix: Debian packages with tar.gz data file #99

Closed jjmaestro closed 2 months ago

jjmaestro commented 2 months ago

When a Debian package has a data file that's already compressed with gzip and named data.tar.gz it fails with:

Error in genrule: rule 'data' has file 'data.tar.gz' as both an input and an output.

See issue #98

jjmaestro commented 2 months ago

It passes all the current tests and I've manually tested it in a development branch with one of the problematic CUDA packages. This fix seems to work and the CUDA packages don't fail like they did before. However, I can't get that test to pass as it fails on yet-another issue that I'm trying to debug.

Still, I think the diff is easy to follow and I think it's good to go.

jjmaestro commented 2 months ago

@thesayyn I think this fix should go first and then I'll rebase the refactor and other branches. What do you think?

thesayyn commented 2 months ago

Bear with me as i work through these PRs :) FYI It may take days/weeks.

jjmaestro commented 2 months ago

@thesayyn of course!! no worries :) I'll keep the PRs rebased and up-to-date!