search

Goutte / godot-addon-animated-shape-2d

Godot addon to animate a CollisionShape2D along with the frames of an AnimatedSprite2D. Useful for making changing hitboxes, hurtboxes and hardboxes. Comes with an Editor, making things easy.
MIT License
130 stars 1 forks source link

Failure when using AnimatedShape2D as root node of a scene #8

Closed Margad0413 closed 10 months ago

Margad0413 commented 10 months ago

screenshot_01

image

The animated shape window at the bottom of that photo does not appear at all. What's the problem?

Goutte commented 10 months ago

I never tried adding the AnimatedShape2D as root node (the issue is here), nor adding nodes as children to it (not the issue).

I can reproduce the issue ; I am investigating it. Well spotted !

Here's what I get in the error output :

editor/editor_node.cpp:8240 - Condition "plugins_list.has(p_plugin)" is true.

It's not obvious to me what's going wrong here.

As a workaround for now, I'd try using the AnimatedShape2D as not the root node.

Goutte commented 10 months ago

@Margad0413 Also, that witch is super cute. :broom: :sparkles:

Goutte commented 10 months ago

The error message I get is related to https://github.com/godotengine/godot/issues/83256 .

That's not our issue.

I figured it out : scene root nodes have no owner.

I'll patch this at some point, for the 1.4.1 release.

Thanks again for the bug report

Goutte commented 10 months ago

I auto-closed this using the commit message ; the fix was submitted to the published addon on the Asset Lib, along with the new 1.4.1 version available here : https://github.com/Goutte/godot-addon-animated-shape-2d/releases/tag/v1.4.1

It's going to be live in a few days at most. Meanwhile you can download the patched addon from here if you want.

Anyway, you should probably never add Node2D as children of plain Nodes, unless you know what you are doing and really want to reset the transform.

It never occurred to me to do that because it feels … mathematically taboo ? :grinning:

Good luck with your game, and do ping me on the fedi when it's live, I want to try it ! (also, it gives me boasting rights, which is the sole salary I get from doing all this)