feat: support esp-idf - Githubissues

GrKoR / esphome_aux_ac_component

ESPHome component for AUX based air conditioners. Direct wifi control of HVAC by ESPHome and Home Assistant. HVAC status and command feedback are available.

Other

209 stars 50 forks source link

feat: support esp-idf #131

Closed itay-sho closed 1 month ago

itay-sho commented 1 month ago

Removing the dependency in Arduino.h which was used only for debugging. fixing some wrong types that made compilation problems in my esp32-c6 - probably due to a newer compiler.

note: this is kind of hacky, but I managed to compile it. might need some more effort to make sure that it works now both on older esp32 and newer ones, and maybe having a "real" F macro.

itay-sho commented 1 month ago

as we discussed in #128 @GrKoR

GrKoR commented 1 month ago

Could you please split this commit into two different commits?

the first one with deleting of Arduino.h and related stuff ("feat: support esp-idf" itself)
the second one with formatting fix (all changes related to the addition of "PRIu32")

itay-sho commented 1 month ago

Hey, worked on the comment you've suggested checked by compiling and redeploying again to my esphome.

GrKoR commented 1 month ago

@itay-sho Hey, Itay! I created new brunch with esp-idf support. I need to test it on different platforms. After that I'll push it into the master branch. Thank you a lot for your help!

konstantin89 commented 1 month ago

@itay-sho thanks for the fix!