GrandOrgue / grandorgue

GrandOrgue software
Other
149 stars 39 forks source link

Support of MacOs 11 causes github builds to fail #1791

Closed oleg68 closed 4 months ago

oleg68 commented 5 months ago

Two weeks ago all github builds started failing. Example: https://github.com/GrandOrgue/grandorgue/actions/runs/7738623443

The reason is the unability to install required dependencies:

==> Installing imagemagick dependency: libvmaf
==> meson build
==> ninja -vC build
Last 15 lines from /Users/runner/Library/Logs/Homebrew/libvmaf/02.ninja:
clang -Isrc/libvmaf.3.dylib.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -pedantic -DOC_NEW_STYLE_INCLUDES -MD -MQ src/libvmaf.3.dylib.p/meson-generated_.._vmaf_v0.6.1neg.json.c.o -MF src/libvmaf.3.dylib.p/meson-generated_.._vmaf_v0.6.1neg.json.c.o.d -o src/libvmaf.3.dylib.p/meson-generated_.._vmaf_v0.6.1neg.json.c.o -c src/vmaf_v0.6.1neg.json.c
src/vmaf_v0.6.1neg.json.c:1630:1: error: unknown type name 'size_t'
size_t src_vmaf_v0_6_1neg_json_len = 19519;
^
1 error generated.
[44/165] clang -Isrc/liblibvmaf_feature.a.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -I../src/cuda -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -MD -MQ src/liblibvmaf_feature.a.p/feature_cambi.c.o -MF src/liblibvmaf_feature.a.p/feature_cambi.c.o.d -o src/liblibvmaf_feature.a.p/feature_cambi.c.o -c ../src/feature/cambi.c
[45/165] clang -Isrc/libvmaf.3.dylib.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -pedantic -DOC_NEW_STYLE_INCLUDES -MD -MQ src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -MF src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o.d -o src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -c src/vmaf_b_v0.6.3.json.c
FAILED: src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o 
clang -Isrc/libvmaf.3.dylib.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -pedantic -DOC_NEW_STYLE_INCLUDES -MD -MQ src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -MF src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o.d -o src/libvmaf.3.dylib.p/meson-generated_.._vmaf_b_v0.6.3.json.c.o -c src/vmaf_b_v0.6.3.json.c
src/vmaf_b_v0.6.3.json.c:34077:1: error: unknown type name 'size_t'
size_t src_vmaf_b_v0_6_3_json_len = 408883;
^
1 error generated.
[46/165] clang -Isrc/liblibvmaf_feature.a.p -Isrc -I../src -Iinclude -I../include -I../src/feature -I../src/feature/common -I../src/cuda -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -std=c11 -O3 -D_DARWIN_C_SOURCE -MD -MQ src/liblibvmaf_feature.a.p/feature_integer_adm.c.o -MF src/liblibvmaf_feature.a.p/feature_integer_adm.c.o.d -o src/liblibvmaf_feature.a.p/feature_integer_adm.c.o -c ../src/feature/integer_adm.c
ninja: build stopped: subcommand failed.

Do not report this issue to Homebrew/brew or Homebrew/homebrew-core!

Error: You are using macOS 11.
We (and Apple) do not provide support for this old version.
It is expected behaviour that some formulae will fail to build in this old version.
It is expected behaviour that Homebrew will be buggy and slow.
Do not create any issues about this on Homebrew's GitHub repositories.
Do not create any issues even if you think this message is unrelated.
Any opened issues will be immediately closed without response.
Do not ask for help from Homebrew or its maintainers on social media.
You may ask for help in Homebrew's discussions but are unlikely to receive a response.
Try to figure out the problem yourself and submit a fix as a pull request.
We will review it but may or may not accept it.

Error: Process completed with exit code 1.

I'm planning to stop support of MacOs 11 and to require the minimum MacOs version as 12.

@larspalo @rousseldenis Do you agree?

larspalo commented 5 months ago

I'm planning to stop support of MacOs 11 and to require the minimum MacOs version as 12.

@larspalo @rousseldenis Do you agree?

Yes.

rousseldenis commented 5 months ago

@larspalo @rousseldenis Do you agree?

Of course