GrandOrgue / grandorgue

GrandOrgue software
Other
172 stars 43 forks source link

Implemented Load/Save in GODeviceNamePattern #1948

Closed oleg68 closed 3 months ago

oleg68 commented 4 months ago

This is a next PR retated to #1265

It moves the loading/saving config code from GOMidiDeviceConfigList to GOMidiDeviceConfig and GODeviceNameConfig.

It will be reused for audio devices later.

It is just refactoring. No GO behavior should be changed.

oleg68 commented 4 months ago

After some testing I noted that this PR makes an incompatible GrandOrgueConfig changes with earlier versions. This is an undesired behavior and should be fixed before merging.

oleg68 commented 4 months ago

I fixed the configuration incompatibility. So you may check this PR

oleg68 commented 3 months ago

@rousseldenis could you approve this pr?