search

GrandOrgue / grandorgue

GrandOrgue software
Other
172 stars 43 forks source link

Fix InfoFilename handling #1952

Closed larspalo closed 3 months ago

larspalo commented 3 months ago

This PR attempts to fix two issues with the InfoFilename which has a value that is not mandatory to include in the odf at all. The issues are:

  1. If value is present but can not be opened/handled by GO for any reason (typo etc.) the whole organ loading would abort.
  2. If value is present and possible to handle by GO, wxFileName::FileExists() would still fail (at least under Linux) if path supplied isn't absolute. Thus, even if a valid relative path exists, the more info link wouldn't be shown in the info dialog.

With this PR, and as the value is not mandatory in the odf, a log warning for an invalid file will be supplied only if strict checking is enabled, but the organ will continue to load. Also the correct more info link to the InfoFilename will be shown if the file is valid/existing.

oleg68 commented 3 months ago

@larspalo could you add a changelog entry?

oleg68 commented 3 months ago

@larspalo @rousseldenis do we want to include this change to 3.15.0? If so, please resolve the conflict and approve it.

oleg68 commented 3 months ago

@rousseldenis could you approve this pr?