search

GrandOrgue / grandorgue

GrandOrgue software
Other
172 stars 43 forks source link

Renamed GOSetter::m_swell to m_CrescendoCtrl #2014

Closed oleg68 closed 1 month ago

oleg68 commented 1 month ago

This is a next PR related to the crescendo.

It just renames m_swell to m_CrescendoEnclosure.

No GO behavior should be changed.

larspalo commented 1 month ago

@oleg68 Do you realize that a crescendo pedal has nothing at all with an enclosure to do?

oleg68 commented 1 month ago

@oleg68 Do you realize that a crescendo pedal has nothing at all with an enclosure to do?

In the real life - yes. But GrandOrgue uses the same GOEnclosure class for both swell/enclosures and crescendo.

Earlier GOSetter had the m_swell member for handling crescendo pedal. It was not clear. So I rename it to m_CrescendoEnclosure. Crescendo - because it is used for handling crescendo, Enclosure - because it has the GOEnclosure * datatype. If you disagree, I may rename it to m_CrescendoPedalCtl.

larspalo commented 1 month ago

I may rename it to m_CrescendoPedalCtl

I like that much better, yes.

The visual (GUI) expression pedal rendering of swell/enclosure (enclosed swell box) and the crescendo (register crescendo) might very well be of the same type even if the crescendo in real life also might be done as a Rollschweller type. The backend functionality and model is vastly different for them though. Perhaps it could be a future area of improvement to more clearly differentiate between them...

oleg68 commented 1 month ago

I like that much better, yes.

Renamed to m_CrescendoCtrl