search

GrandOrgue / grandorgue

GrandOrgue software
Other
172 stars 43 forks source link

Added GODrawStop internal state tests #2026

Closed oleg68 closed 1 month ago

oleg68 commented 1 month ago

The GODrawStop internal state (with the OR switch) was introduced in #2012

This PR:

  1. Adds tests for the new functionality: the collaboration of the button state and the crescendo state.
  2. Fixes a bug detected by this test (removes checking for IsEngaged() from GODrawstop::SetButtonState).
  3. Adoptes the tests to result of #2023 (replaces IsActive() with IsEngaged())

Until #2021 the new internal state is not used, so NO GO behavior should be changed.

oleg68 commented 1 month ago

@larspalo @rousseldenis Could you approve this PR?