Importing distro files from Flatpak and Arch Linux

[cengique]

Imported packaging files and new screenshots @AsciiWolf

[AsciiWolf]

Looks much better now, thanks! :-)

[cengique]

@AsciiWolf just pushed some more commits, please review. Thanks! :)

[AsciiWolf]

Nice, I think it looks good now (except for the screenshots URL)! The only remaining thing are the Makefile rules. :-)

[AsciiWolf]

Although, we should probably sort through the screenshots, select the best ones and remove others. Currently, there are too many of them and some are very similar.

For example, misc/screenshots/c-fedora.png and misc/screenshots/d-fedora.png look almost the same.

[cengique]

Nice, I think it looks good now (except for the screenshots URL)! The only remaining thing are the Makefile rules. :-)

Great! I will sort through the screenshots, but I will need some help with the Makefile.

@wtfbbqhax @jkent can you help crafting an install section in the Makefile that can place binaries, icon, and desktop files in the proper places? As far as I see, we only have one target in the Makefile that just produces a zip or other file based on target distro. So we never worried about an install section. What's the situation with the CMake build? Was that ever working? Thanks!

[cengique]

Looks like libcurl is also outdated and causing Linux build errors due to USE_RESTCLIENT=1.

[cengique]

@AsciiWolf @jkent I added an install: target in the Makefile. I'd appreciate if you can review. Note that the game client is not perfectly working in this branch, so I'll rebase to a release branch to complete testing. I'm looking for general feedback about the changes in the Makefile. Thanks!

@AsciiWolf I removed screenshot d-fedora.png, but kept the newer ones as not all are referenced in the flatpak.

[AsciiWolf]

It looks good except the things that I pointed out. Thanks!

[AsciiWolf]

By the way, we have a CI build failure on Linux:

error: 'CURLMOPT_MAX_TOTAL_CONNECTIONS' conflicts with a previous declaration

Is it the same thing as already mentioned here?

[cengique]

By the way, we have a CI build failure on Linux:

error: 'CURLMOPT_MAX_TOTAL_CONNECTIONS' conflicts with a previous declaration

Is it the same thing as already mentioned here?

That's right, we will work on that separately, but for now you can build with:

USE_INTERNAL_LUA=1 make -j

by removing the building of the REST client.

[cengique]

@AsciiWolf I think I addressed all the issues. Please check! Thanks :)

[AsciiWolf]

So, I have thought about the desktop/icon file name one more time and I come to conclusion that you can probably keep the name at tremulous-grangerhub if you want, but please change the name to a lower case one (tremulous-grangerhub.desktop / tremulous-grangerhub.png). Most desktop files that are in legacy non-rDNS name format have their whole name in lowercase, and it also looks better that way and is more consistent with the original (tremulous.desktop / tremulous.png) name. And don't forget to update the Icon entry in the desktop file to use the correct icon.

But please, consider changing the <name> tag in AppStream metadata from <name>Tremulous-Grangerhub</name> back to <name>Tremulous</name> and adding an information about the GrangerHub Tremulous version to a <description> instead.

Thanks!

[cengique]

So, I have thought about the desktop/icon file name one more time and I come to conclusion that you can probably keep the name at tremulous-grangerhub if you want, but please change the name to a lower case one (tremulous-grangerhub.desktop / tremulous-grangerhub.png). Most desktop files that are in legacy non-rDNS name format have their whole name in lowercase, and it also looks better that way and is more consistent with the original (tremulous.desktop / tremulous.png) name. And don't forget to update the Icon entry in the desktop file to use the correct icon.

But please, consider changing the <name> tag in AppStream metadata from <name>Tremulous-Grangerhub</name> back to <name>Tremulous</name> and adding an information about the GrangerHub Tremulous version to a <description> instead.

Thanks!

Hey @AsciiWolf , thanks for the compromising solution. I was a bit taken aback and wanted a meeting since this was taking too long. We can still have a short meeting to find the best solutions and finalize this. I have no problem changing the name tag in AppStream back to Tremulous. The reason for branding was that there are a couple of different clients around (the other one being Tremfusion) - but I guess we can name that one separately if it comes to it. Also the GrangerHub versions may be buggy and people may want to install vanilla versions (if they can find working ones!). But the GrangerHub info can stay in the description and version fields for now. I will change the files to lowercase as I noticed that it looked awkward in those folders, which mostly contained lowercase tools. Although, I saw a couple of font file names, etc, that had mixed case. Anyways, I'll think about the naming scheme one more time and will go through the list of items you picked above. Thanks.

[AsciiWolf]

Thanks for your reply! Meeting could be a good idea, but I am afraid that my time schedule does not allow me more meetings in upcoming week or two. :-/

Regarding the branding name: Most Linux distributions do not package Tremfusion or vanilla Tremulous anymore, so I would not worry about that. :-)

[cengique]

So, I have thought about the desktop/icon file name one more time and I come to conclusion that you can probably keep the name at tremulous-grangerhub if you want, but please change the name to a lower case one (tremulous-grangerhub.desktop / tremulous-grangerhub.png). Most desktop files that are in legacy non-rDNS name format have their whole name in lowercase, and it also looks better that way and is more consistent with the original (tremulous.desktop / tremulous.png) name. And don't forget to update the Icon entry in the desktop file to use the correct icon.

But please, consider changing the <name> tag in AppStream metadata from <name>Tremulous-Grangerhub</name> back to <name>Tremulous</name> and adding an information about the GrangerHub Tremulous version to a <description> instead.

@AsciiWolf I think I fixed these, but please take a look at my latest commit. Thanks and sorry for the long delay. Too much traveling and not enough time on the computer.

[AsciiWolf]

Thanks! I have provided some feedback.

[cengique]

@AsciiWolf just got around to fixing these issues. If you can check the conversations and resolve, we may be close to being done! If this is all good, I'll rebase this branch to a working release and do more testing.

[AsciiWolf]

Looks very good now (except the few things mentioned before), thanks! :-)