Closed gautamgiri-dev closed 1 year ago
Hi,
Thanks for reaching out. Unfortunately I can't merge these changes as is.
1) you should probably use custom blocks to add your own custom classes when you need more customization. I could agree to an option, but the current design needs a lot of work since it is unclear that vector === media
and class === attributes.class
. Again, probably easier to just use custom blocks on your end.
2) I can't merge the theme changes since it is a breaking change. I'm not a fan of removing the useCustomTheme option and replacing it with something else. Perhaps we can extend it by also allowing an object to be passed down such as:
useCustomTheme: {
primaryColor?: string,
secondaryColor?: string,
quaternaryColor?: string
},
Sure @DRoet, I understand your concerns and we can surely extend the useCustomTheme option.
Also, regarding the blocks I want to provide options to easily add custom classes to the default blocks. I will be refactoring the prop names with something more sensible. Since it's easier for users to customize the existing blocks with look and feel of their choice rather than creating every block as a custom block. Apart from that, I am also thinking to add options to easily customize the svg icons of the default blocks which can be a great timesaver for the developers.
Yeah this can't be merged due to issues already mentioned by @DRoet
colorScheme
option is available inPluginOptions
withprimaryColor
,secondaryColor
andquaternaryColor
as string props to add hex color codes to override the default color scheme.customClasses
option available inPluginOptions
withblocks
prop which handles the customClasses for blocks. This prop containsvector
prop to wrap the svg element with adiv
element with the class provided as the string value.text
prop handles custom class for the labeldiv
wrapper.class
prop can be used to apply custom class on the parentdiv
wrapper for the block. The classes ofblock
prop are applied on all the blocks to make all blocks share the same class which can be used to easily customize their look and feel.index.html
demonstrates how to use the new plugin options