search

GraphBLAS / binsparse-specification

A cross-platform binary storage format for sparse data, particularly sparse matrices.
https://graphblas.org/binsparse-specification/
BSD 3-Clause "New" or "Revised" License
15 stars 4 forks source link

Add language to specify fill value #30

Closed willow-ahrens closed 1 year ago

willow-ahrens commented 1 year ago

fixes #23

github-actions[bot] commented 1 year ago

Automated Review URLs

willow-ahrens commented 1 year ago

@eriknw @jim22k I believe there was consensus on this, requesting review/merge

jim22k commented 1 year ago

whose single element defines the fill (zero) value of the sparse tensor, or the value of the array at indices not otherwise specified by the sparse tensor structure

Can we change this to "whose single element defines the value of indices not specified by the sparse tensor structure"?

I want to make absolutely sure that no one can interpret the fill value as overwriting an explicit zero.

willow-ahrens commented 1 year ago

Yep! I updated the file.

jim22k commented 1 year ago

Looks like there is a merge conflict. Once that is fixed, this should okay to merge.