GrapheneOS / os-issue-tracker

Issue tracker for GrapheneOS Android Open Source Project hardening work. Standalone projects like Auditor, AttestationServer and hardened_malloc have their own dedicated trackers.
https://grapheneos.org/
363 stars 21 forks source link

Change Storage Manager Toggle description to better reflect functionality #2137

Open AdiPathak97 opened 1 year ago

AdiPathak97 commented 1 year ago

Currently, Storage Manager Toggle (Settings > Storage > Storage Manager) gives the following informative text: "To help free up storage space, storage manager removes backed up photos and videos from your device."

However, from a discussion I found on the forum, GrapheneOS does not have backup detection, and that it straight up removes media older than the set time period. This is a significant difference from what the toggle describes, as it can easily result in a scenario where the user believes certain data they haven't backed up is safe, but the storage manager deletes that data and its gone forever.

The description should remove the term "backed up" (thus making the informative text: "To help free up storage space, storage manager removes photos and videos from your device." or something to that effect). In addition, a warning popup with this message may also be warranted, as this description can be viewed currently only if the user clicks the Storage Manager Toggle name to learn more, and its not necessary to do so to activate the Storage Manager.

girlbossceo commented 1 year ago

We'd rather disable this feature from being used entirely as it doesn't serve much value if all it does is purge media without detecting or checking for any kind of backup provider. Pixels have plenty of storage now so this isn't super useful.