GrapheneOS / os-issue-tracker

Issue tracker for GrapheneOS Android Open Source Project hardening work. Standalone projects like Auditor, AttestationServer and hardened_malloc have their own dedicated trackers.
https://grapheneos.org/
365 stars 21 forks source link

Include a quirk for Apple 3.5mm headphone dongle #4373

Open surfaceflinger opened 1 week ago

surfaceflinger commented 1 week ago

Apple dongles are quite popular, cheap and commonly recommended which leads to people buying them without verifying how they work on Android. Unfortunately, they have a separate on-board volume control which is set to 50% on every power on.

There's a discussion here https://issuetracker.google.com/issues/242221770?pli=1 and Google still hasn't included a "fix" for that. Would this be simple enough to get included in GrapheneOS? https://github.com/polkaulfield/android_kernel_google_gs101/commit/fd86681a040119610bd54b02c7e152e03f8cff7c I don't think it would be harmful in any way and users wouldn't need to download weird proprietary apps to just raise the onboard volume to 100%.

There's also this but I have no idea about Android development and if this would work :shrug: https://issuetracker.google.com/issues/242221770#comment100

An-anonymous-coder commented 5 days ago

Another issue with 3.5mm adapters: Would it be possible to securely switch the audio source to the dongle while the phone is locked and Settings > Security & privacy > Exploit protection > USB-C port > Charging-only when locked is enabled?

A built-in headphone jack would do this just fine, but we don't have that. Maybe there could be an exception toggle in place?

thestinger commented 5 days ago

No, and not related. You can already continue using it while locked if it's already connected.

surfaceflinger commented 4 days ago

Not sure what exactly are the differences in dongles around the world. Are US dongles booting with 100% vol or do they start at 50% too but 50% is louder on them? If it's the first case then testing on an US unit could be misleading as if it didn't work :wink: Let me know if there would be a need to run an experimental build since I have a EU unit :^) or I guess it would be also enough to set the volume to 1% or something to make sure it has an effect on all variants

An-anonymous-coder commented 3 days ago

I have a US unit. I can't verify with certainty that it's at 50%, but considering setting the device to full volume is a comfortable volume for most listening, I would say that's the case.