search

GraphiteEditor / Graphite

2D vector & raster editor that melds traditional layers & tools with a modern node-based, non-destructive, procedural workflow.
https://graphite.rs
Apache License 2.0
9.63k stars 468 forks source link

Allow the Pen tool to connect layers by their endpoints, merging into a single layer #2076

Closed adamgerhant closed 3 weeks ago

adamgerhant commented 1 month ago

Closes #2077

Keavon commented 1 month ago

We have a little bit of a bug in this document:

https://github.com/user-attachments/assets/c0f34752-8884-4842-a65a-14b0eb678f21

Keavon commented 1 month ago

I'll temporarily mark this as a draft until then. Please undo that when it's ready.

Keavon commented 1 month ago

Because of the force pushes, it's hard for me to see exactly what changes you made. However, testing this again in the latest build link, the issue I showed above still exists 😢 I'll mark this as a draft again in the meantime to make it easier to get through my review backlog. As always, please un-mark as draft when it's ready (and perhaps ping me). Thanks.

Keavon commented 3 weeks ago

Seems perfect now, except for one issue we can defer to another PR and basically call a new feature instead of a bug: we want the Pen tool to only add to an existing path (which seems to happen now for any selected layer that has a Path node) if a checkbox is selected in its tool options bar, rather than by default, since that could confuse users how new layers aren't being created and instead new subpaths are being added.