Issue/2120 support the new image choice and multiple choice fields in gravity forms 29

[omarkasem]

• Implements https://github.com/GravityKit/GravityView/issues/2120
• Support the option to choose what to display, choice, value, or image (for image choices) on the field options modal for both fields.
• Fixed both fields doesn't show the selected choice when editing (but allows it to be edited)
• Added both fields to the Search Bar

💾 Build file (9f627988e).

[mrcasual]

@Mwalek, please test.

[rafaehlers]

@Mwalek FYI, there's an instaWP site with 2.9 here:

Form: https://29beta.try.gravitykit.com/wp-admin/admin.php?page=gf_edit_forms&id=44 View: https://29beta.try.gravitykit.com/wp-admin/post.php?post=3139&action=edit

[Mwalek]

@omarkasem the only issue I observed was that the setting "Enable lightbox for images" doesn't work for image choices. Could you please have a look?

[rafaehlers]

@omarkasem the only issue I observed was that the setting "Enable lightbox for images" doesn't work for image choices. Could you please have a look?

@Mwalek Sorry to ask, but why is that important in this scenario? Images used on Image Choice fields shouldn't be expanded or opened in a lightbox. Unless I'm missing something. Let me know.

[Mwalek]

@rafaehlers I wouldn't say it's important, but I would say that it's expected. From a user standpoint, if the "Enable lightbox for images" setting is enabled, they would be expecting ALL images to open in a lightbox, regardless of how the image was added.

Images used on Image Choice fields shouldn't be expanded or opened in a lightbox. Unless I'm missing something.

Is there a particular reason for this? When an image from the Image Choice Field is added it doesn't look very different from an image added via another field, and yet it would perform differently. I think users might find that confusing.

Just my thoughts. We can safely ignore this if the current behavior is intended.

[rafaehlers]

@Mwalek Image Choices are just images added to radio buttons or checkbox fields to help illustrate the choice. It's not related to File Uploads at all. These images can be small icons.

On the form, when you click on a choice to select it, the choice is selected. That's it. The image is not expanded. I don't want a small icon to be expanded inside a lightbox. The View should have a similar behavior.

Does that make sense?