search

GreenleafLab / ArchR

ArchR : Analysis of Regulatory Chromatin in R (www.ArchRProject.com)
MIT License
387 stars 140 forks source link

add version argument for writing gene expression to hdf5 #2160

Closed szcf-weiya closed 6 months ago

szcf-weiya commented 6 months ago

I noticed that the current package has introduced version argument, along with other new arguments in the addMatToArrow function,

https://github.com/GreenleafLab/ArchR/blob/65968a4068253783fe6b0918efcbf7d216a49ee7/R/ArrowWrite.R#L105-L126

but the higher-level function addGeneExpressionMatrix does not support passing those new arguments.

This pull request aims to provide the option to use the hdf5 style of the old version (version = 1).