GregBartlett / sonar-resharper

MIT License
9 stars 21 forks source link

Resharper plugin related error in General Settings #23

Closed mmajcica closed 7 years ago

mmajcica commented 8 years ago

Since I upgraded Sonar to version 6.1 I do see in general settings the following message:

'sonar.resharper.installDirectory' and 'sonar.resharper.inspectCodePath' cannot be used at the same time as they refer to the same setting

image

Does anyone know why of it and how to fix it?

GregBartlett commented 8 years ago

I wouldn’t use this plugin at this time.. it is SO FAR out of date and hasn’t been brought up from the 4.5 plugin and soooo much has changed.

I’m half tempted to just rewrite it using the 5.6 plugin api and take what I can from the original. Just a lot of deprecated code :(

From: Mario Majcica [mailto:notifications@github.com] Sent: Tuesday, October 25, 2016 9:32 AM To: SonarQubeCommunity/sonar-resharper sonar-resharper@noreply.github.com Subject: [SonarQubeCommunity/sonar-resharper] Resharper plugin related error in General Settings (#23)

Since I upgraded Sonar to version 6.1 I do see in general settings the following message:

'sonar.resharper.installDirectory' and 'sonar.resharper.inspectCodePath' cannot be used at the same time as they refer to the same setting

https://cloud.githubusercontent.com/assets/3026551/19687994/028199b0-9ac8-11e6-80fc-d0256388f50d.png

Does anyone know why of it and how to fix it?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SonarQubeCommunity/sonar-resharper/issues/23 , or mute the thread https://github.com/notifications/unsubscribe-auth/AD8kaxNEQUlYz3NI8mZLTNhtr-ylBHyHks5q3gTPgaJpZM4Kf_Ly . https://github.com/notifications/beacon/AD8ka_Wjxv2XaBdR4DOCLy9XdaULlIuPks5q3gTPgaJpZM4Kf_Ly.gif

mberubenet commented 7 years ago

Any plan to fix that plugins soon ? Losing the Resharper integration is a big problem. I don't know much how SonarQube works but this error message prevent the settings to display properly. It there a workaround ? Thanks

GregBartlett commented 7 years ago

Oh wait this was the 6.1 thread.  No I haven't gotten this thing going for that. I don't have an eta, sonar documentation for plug in development isn't very good and am still trying to understand it

Sent via the Samsung Galaxy Note® 4, an AT&T 4G LTE smartphone

-------- Original message -------- From: mberubenet notifications@github.com Date: 2/7/17 7:58 PM (GMT-05:00) To: SonarQubeCommunity/sonar-resharper sonar-resharper@noreply.github.com Cc: GregBartlett gregory.m.bartlett@gmail.com, Comment comment@noreply.github.com Subject: Re: [SonarQubeCommunity/sonar-resharper] Resharper plugin related   error in General Settings (#23)

Any plan to fix that plugins soon ? Losing the Resharper integration is a big problem. I don't know much how SonarQube works but this error message prevent the settings to display properly. It there a workaround ? Thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/SonarQubeCommunity/sonar-resharper","title":"SonarQubeCommunity/sonar-resharper","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/SonarQubeCommunity/sonar-resharper"}},"updates":{"snippets":[{"icon":"PERSON","message":"@mberubenet in #23: Any plan to fix that plugins soon ? Losing the Resharper integration is a big problem. I don't know much how SonarQube works but this error message prevent the settings to display properly. It there a workaround ? Thanks"}],"action":{"name":"View Issue","url":"https://github.com/SonarQubeCommunity/sonar-resharper/issues/23#issuecomment-278195498"}}}

mberubenet commented 7 years ago

Well, for what I see, version 2.0 of the plugins works pretty well on SonarQube 6.2 except for the error message specified at the beginning of the post the prevent the setting page to display ANY values. My guest (but I'm not an expert in SonarQube in anyway) is that if you comment line 102 or 115 of ReSharperPlugins.java, the settings page of SonarQube should stop complaining about 2 keys for the same property. I wish I could submit a pull request myself but I haven't done java since college (I'm a C# dev you can guess) and even if I can propably write the code, I unfortunately don't know much about the modern java tool chain (maven, appveyor, jUnit etc,). It's not the thing the teach you at school !

Doing that, I'm pretty sure the plugins will work well enough to continue to be used until an update to the 6+ API is done. If you think it could break older versions of SonarQube, maybe start an hotfix branch for that.

If you found proper documentation about that and maybe you could gave me some tips on how to setup a working java development environment, I would be glad to help you on that. We rely a lot on ReSharper and that integration is a must for us.

Thanks

GregBartlett commented 7 years ago

Thank you. Let me get the build working on appveyor and take a look at whether your suggestions will break anything for prior versions. I’m by no means a java developer. I’m a C# .Net Developer as well, who tinkers ;)

From: mberubenet [mailto:notifications@github.com] Sent: Wednesday, February 8, 2017 8:59 AM To: SonarQubeCommunity/sonar-resharper sonar-resharper@noreply.github.com Cc: GregBartlett gregory.m.bartlett@gmail.com; Comment comment@noreply.github.com Subject: Re: [SonarQubeCommunity/sonar-resharper] Resharper plugin related error in General Settings (#23)

Well, for what I see, version 2.0 of the plugins works pretty well on SonarQube 6.2 except for the error message specified at the beginning of the post the prevent the setting page to display ANY values. My guest (but I'm not an expert in SonarQube in anyway) is that if you comment line 102 or 115 of ReSharperPlugins.java, the settings page of SonarQube should stop complaining about 2 keys for the same property. I wish I could submit a pull request myself but I haven't done java since college (I'm a C# dev you can guess) and even if I can propably write the code, I unfortunately don't know much about the modern java tool chain (maven, appveyor, jUnit etc,). It's not the thing the teach you at school !

Doing that, I'm pretty sure the plugins will work well enough to continue to be used until an update to the 6+ API is done. If you think it could break older versions of SonarQube, maybe start an hotfix branch for that.

If you found proper documentation about that and maybe you could gave me some tips on how to setup a working java development environment, I would be glad to help you on that. We rely a lot on ReSharper and that integration is a must for us.

Thanks

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SonarQubeCommunity/sonar-resharper/issues/23#issuecomment-278335718 , or mute the thread https://github.com/notifications/unsubscribe-auth/AD8ka9Faoyg3oBz37RY_yA9zyAT5lAaKks5racovgaJpZM4Kf_Ly . https://github.com/notifications/beacon/AD8ka_skUYh7Glw9SsdAVyX70cFFNnn0ks5racovgaJpZM4Kf_Ly.gif

GregBartlett commented 7 years ago

@mberubenet .. I removed the install path variable as it wasnt being used anywhere. Look for release > 2.16 in a little bit while i pull and build and release

GregBartlett commented 7 years ago

@mmajcica @mberubenet v2.17 released, give it a shot in a test environment first if you have one

mberubenet commented 7 years ago

I will. Thanks a lot for your effort, I'll tell you how it goes.

GregBartlett commented 7 years ago

👍

mberubenet commented 7 years ago

Just tested it. Looks good. Analysis still work as expected and no more error it the administration and project setting page. Thanks again !

GregBartlett commented 7 years ago

awesome, I'll close out this issue. Is the other issue where it's doing the duplicate lines thing gone too?

GregBartlett commented 7 years ago

this one: https://github.com/GregBartlett/sonar-resharper/issues/21

mberubenet commented 7 years ago

I confirm there's a lot less of the "Skipped the Resharper issue" message now. In my specific case, went from 85405 to 0 ! I don't know if it "works" (is the message will appear in a real error case ?) but looks like an improvement to me.

GregBartlett commented 7 years ago

Yeah I think originally the default was INFO and it was changed to only show if you tell it to be more verbose. When I have time I'll look at the code more closely to figure out why it happens in general, but thanks for taking a look.