search

GregBartlett / sonar-resharper

MIT License
9 stars 21 forks source link

Fix SONARRSHPR-21 and lowered logging level of 'skipping issue' message #9

Closed rikvandenberg closed 8 years ago

rikvandenberg commented 8 years ago

Hi All,

Intro Currently we have several builds consisting of 15+ projects. ReSharper Inspectcode outputs a file consisting of 10.000 issues. When the MSBuild.SonarQube.Runner is parsing this report for each project, it generates a large volume of 'INFO' messages in our diagnostic build logs. Atleast 75% of those issues is not related to that project that is being analyzed and it generates the Skipping the Resharper issue on line XX whose file is not in SonarQube message.

TFS Build agents stores diagnostic build files in the %TEMP% location. We have had files up to 100MB per build log, per day, and thus our storage disks are filling up faster then anticipated. We have taken some measures in our infrastructure to prevent this.

Additionally, large build diagnostics caused the TFS web portal to be almost non-responsive when viewing the diagnostics.

Pull Request All in all, this pull request is here to relieve us some of our pain and fix a bug for you. I have:

Would you be so kind to review the suggested changes to the sensor and parser. Please let me know if there are any additional tasks that need to be completed regarding this pull-request

Kind Regards,

Rik

Issue that will be fixed: SONARRSHPR-21

dbolkensteyn commented 8 years ago

Thanks @rikvandenberg - this is a nice pull request indeed, thanks for the tweet too ;)

This will be part of the ReSharper plugin 2.0.1 which I've just scheduled for the end of next week: https://jira.sonarsource.com/jira/secure/ReleaseNote.jspa?projectId=10943&version=12490

rikvandenberg commented 8 years ago

@dbolkensteyn Thanks for taking the time to review. I just noticed a post was opened a few days ago which describes the exact same problem by Johan. We are currently upgrading to 5.3 and we look forward to this new version.

jheier commented 8 years ago

The ReSharper plugin 2.0.1 release date is changed to 18-03-2016!

BrightLight commented 8 years ago

Now there's no release date at all any more (https://jira.sonarsource.com/browse/SONARRSHPR/fixforversion/12490/?selectedTab=com.atlassian.jira.plugins.jira-development-integration-plugin:release-report-tabpanel) @dbolkensteyn would you please consider releasesing a new version that at least contains this fix? Our build runs several ours right now.

ganncamp commented 8 years ago

@rikvandenberg we've moved this plugin to the community and no longer maintain it directly. Let us know if you'd like to take over maintenance of this. Then you could merge your own PR. :-) cc @BrightLight

GregBartlett commented 8 years ago

Where was it moved too? I just upgraded to sonarqube 5.6 and can't believe the R# plugin was deprecated...

ganncamp commented 8 years ago

It's moved to right here @GregBartlett, but SonarSouce doesn't maintain it anymore.

GregBartlett commented 8 years ago

Thanks, guess I misunderstood. So someone needs to take this over in order to get commit fixes from others and put releases together. Basing that on the comment you made 21 days ago to @rikvandenberg , am I right? Sorry kind of new to this whole github stuff and the open community.

ganncamp commented 8 years ago

It doesn't have to be him @GregBartlett. He showed an interest, so I invited him to take it over. But you've shown an interest now too... :-)

GregBartlett commented 8 years ago

@ganncamp lol well... let me review the code base and issues people have reported. The main reason I had removed it from my sonarqube to begin was for this particular issue and creating a ton of noise on the server where it ran in terms of file size. If I decide to take it on, that just telling you and you make it happen?

rikvandenberg commented 8 years ago

Sorry for the late response all.

@ganncamp Sorry, but I'm not proficient enough with Java to take over this task. :-)

@GregBartlett @ganncamp This is just basicly an internal fix I've been using and I've compiled my own 'snapshot' of the plugin and deployed it onto our 5.2 environment. It has since then still continue to work and our server is now on version 5.6

@ganncamp With the computation engine now in place, would this fix have more influence on engine or on the scanner?

@GregBartlett If you plan to task yourself with maintaining this plugin, and you require me to improve some of the code I've written, please let me know and I will see to it.

ganncamp commented 8 years ago

@GregBartlett yes. Tell me you want to be the maintainer and I'll take care of getting you permissions to manipulate the repo.

@rikvandenberg I'm not familiar enough to answer your questions. Maybe @tvsonar will chime in.

GregBartlett commented 8 years ago

I guess let's do this, I'd like to be the maintainer.

ganncamp commented 8 years ago

Great @GregBartlett! I've requested the perms. You should have them this week. I'll let you know when I hear back.

ganncamp commented 8 years ago

You should have an invite in your inbox @GregBartlett .

GregBartlett commented 8 years ago

I did thanks.

From: G. Ann Campbell [mailto:notifications@github.com] Sent: Monday, August 15, 2016 8:57 AM To: SonarQubeCommunity/sonar-resharper sonar-resharper@noreply.github.com Cc: GregBartlett gregory.m.bartlett@gmail.com; Mention mention@noreply.github.com Subject: Re: [SonarQubeCommunity/sonar-resharper] Fix SONARRSHPR-21 and lowered logging level of 'skipping issue' message (#9)

You should have an invite in your inbox @GregBartlett https://github.com/GregBartlett .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SonarQubeCommunity/sonar-resharper/pull/9#issuecomment-239795158 , or mute the thread https://github.com/notifications/unsubscribe-auth/AD8ka2RoGIz87-zjDTbCxl4f2qKYI0pAks5qgGIMgaJpZM4G1Kvf . https://github.com/notifications/beacon/AD8ka50D6Ae4q8bow1yqfs8WXVQznDEdks5qgGIMgaJpZM4G1Kvf.gif