GregTech6 / gregtech6

This is the Official Repository of the Mod GregTech 6 for Minecraft 1.7.10
https://gregtech.mechaenetia.com
Other
188 stars 53 forks source link

[Doc] Inconsistency of the effect of IC2 Coolant between code and `gt6fission.pdf` #117

Closed Tanimodori closed 1 year ago

Tanimodori commented 1 year ago

gt6fission.pdf (archived)

F(D}PJ4LFE1%Q{HEZ1YA% S

https://github.com/GregTech6/gregtech6/blob/75e724c721f57d1c7f76c5e91ce472d51f775489/src/main/java/gregtech/tileentity/energy/reactors/MultiTileEntityReactorRodNuclear.java#L179-L183

IIRC the description Decreases divisor of factor stat of fuel rods by 1. should be like tNeutronDiv -= 1; in code. Is gt6fission.pdf incorrect here?

GregoriusT commented 1 year ago

@Erik3003 this would be your thing to know, since you wrote it. ^^

Tanimodori commented 1 year ago

I recalled that Erik wrote that pdf based on an in-game book https://github.com/GregTech6/gregtech6/issues/80#issuecomment-1117343247. So those lines may need a revision. ^ ^

https://github.com/GregTech6/gregtech6/blob/75e724c721f57d1c7f76c5e91ce472d51f775489/src/main/java/gregtech/loaders/b/Loader_Books.java#L635-L636

Tanimodori commented 1 year ago

Possible typo

https://github.com/GregTech6/gregtech6/blob/75e724c721f57d1c7f76c5e91ce472d51f775489/src/main/java/gregtech/loaders/b/Loader_Books.java#L664

For the greatest efficiency you want 
your neutron count one the fuel rod 
                   ^^^ Should be on
stay beneath the maximum stat of that 
fuel rod at all times, while coming 
as close to it as you can.
Erik3003 commented 1 year ago

Yeah, that are typos. The "Deceases divisor of factor stat of fuel rods by 1." is probably a remnant of the older CO2 coolant description.

It should be: "Multiplies emission stat of fuel rods by 4. Multiplies factor stat of fuel rods by 2.",

And the "one" should obviously also be "on".

Tanimodori commented 1 year ago

https://github.com/GregTech6/gregtech6/blob/75e724c721f57d1c7f76c5e91ce472d51f775489/src/main/java/gregtech/loaders/b/Loader_Books.java#L678

To archive really high neutron counts, 
   ^^^^^^^ achieve?
it is advisable to utilize a critical 
reactor design, though it is also feasible 
to run a burner reactor as a stable design.

@Erik3003 May I ask if I've just found another typo? archive doesn't make sense here.

Tanimodori commented 1 year ago

https://github.com/GregTech6/gregtech6/blob/75e724c721f57d1c7f76c5e91ce472d51f775489/src/main/java/gregtech/loaders/b/Loader_Books.java#L686

Emitting 900 neutrons onto the same 
breeder rod with a loss of 500 neutrons 
would mean that 400 neutrons would 
end up on the breeder rod, meaning that 
they would be added to the process of 
turning into an enriched rod each tick.
                                  ^^^^ second

There are many "each tick" phrases used. But afaik fission is calculated per second (one tick in a second). I don't think it is accurate to use "each tick" especially the above one. The progress of breeding should be 400 neutrons per second rather than 400n per tick.

Erik3003 commented 1 year ago

The archive/achieve thing is a typo, the ticks/seconds things is not. Neutron count on the rods only changes every second, but they get added to the breeding process every tick, just like how energy gets output every tick.

Tanimodori commented 1 year ago

So that the update of neutrons count is separated from the update of breeding process and HU output. Thanks for your answering.

Tanimodori commented 1 year ago

I've opened a PR that aimed at fixing the in-game description in the book "Fission Reactor Manual" as pointed out above. Extra work is needed to release a new version of the gt6fission.pdf by Erik.