GregTechCE / GregTech

GregTech rewrite for modern versions of Minecraft
GNU Lesser General Public License v3.0
269 stars 150 forks source link

[Suggestion]API-fy CoverMachineController #1309

Open galyfray opened 3 years ago

galyfray commented 3 years ago

The Idea is making able to easly add more machine controller to addons like AE2 connected controller, controller not only based on redstone signal

Additional context The Idea could be to create an abstract class in api with some usefull default methods like getOtherController. To provide a good compatibility between controllers an abstract method to know if the controller is controlling the machine itself or no.

This is a small proposition to open discussion so if you have any Idea about what should this apy ne able to do or how it should be implemented say it ;).

LAGIdiot commented 3 years ago

Well Machine Controller is item provided by GTCE and it is not meant to be part of API. But with API alone you can create own covers which may control if machine works. Right now there are now helper functions which will provide info regarding other covers of similar function and I am not sure there is need for them.

Can you be more specific about how this could be used and what it would bring to GTCE?

galyfray commented 3 years ago

I am also not sure if there is need for them I would like other people , add-on maker, modpack makers to talk if they find the idea interesting. About use here are some ideas I found(doesn't mean there a good ;-) ).

LAGIdiot commented 3 years ago

Well now then this seems interesting. And could lead to some funny contraptions. Okay let's leave this open for discussion a and I hope others (I am looking at you addon/modpack makers) come up with more stuff.