GregoryAM-SP / The-Minecraft-Overviewer

The Minecraft Overviewer | Successor
https://overviewer.gregoryam.com
GNU General Public License v3.0
88 stars 12 forks source link

Overviewer 1.20.2 / MC 1.20 | Cropped Render cut off at southern border #17

Closed HowDenKing closed 1 year ago

HowDenKing commented 1 year ago

Initially reported in the old project, this issue seems to persist in this updated version too.

Issue Description: When using the crop feature, the bottom row of images is not displayed / rendered. This issue starts happening with renders that have a configured render-depth of roughly -50 or less. regular renders are unaffected by this issue. Example:

image

Settings used for this render:

'dimension': 'overworld', 'center': [0,64,0], 'crop': (-160,-160,143,143)

Current Workaround: create a cropped copy of the world, then render this copy without the setting. As such impact is low / trivial, however it would be nice to cut out that middle step.

Gregory-AM commented 1 year ago

I'll take a look at this! Thank you for bringing this up, as I haven't gone through every configuration setting available on Overviewer.

Gregory-AM commented 1 year ago

@HowDenKing, So I looked into this. I was able to reproduce the issue.

However, every attempt at modifying the Crop feature yielded no positive results; only map breaking results. I even went through the documentation for Overviewer to see if there was a possible fix using other methods, and I was unable to locate one.

Can you provide the work around in a step-by-step comment?

Do you just remove the crop feature after using it in your initial render?

HowDenKing commented 1 year ago

Was worth a shot. Thank you for attempting to solve it, though.

Can you provide the work around in a step-by-step comment? Do you just remove the crop feature after using it in your initial render?

/edit: I forgot to mention I copy the region with mcaselector.

It is the same process as how one would remove excess chunks.

Gregory-AM commented 1 year ago

@HowDenKing, So I looked into this. I was able to reproduce the issue.

However, every attempt at modifying the Crop feature yielded no positive results; only map breaking results. I even went through the documentation for Overviewer to see if there was a possible fix using other methods, and I was unable to locate one.

Can you provide the work around in a step-by-step comment?

Do you just remove the crop feature after using it in your initial render?

Are you using any external softwares? Such as MCA Selector? Saw your edit come in and mention this.

Gregory-AM commented 1 year ago

@HowDenKing, https://github.com/GregoryAM-SP/The-Minecraft-Overviewer/releases/tag/v1.20.3

This fixes the issue you were having.

Edit: You shouldn't have to rely on creating copies anymore. 👍