search

GregoryAM-SP / The-Minecraft-Overviewer

The Minecraft Overviewer | Successor
https://overviewer.gregoryam.com
GNU General Public License v3.0
88 stars 12 forks source link

Biome support? #19

Open Zottelchen opened 1 year ago

Zottelchen commented 1 year ago

Hi, quick question.

Do I somehow need to enable biome support for this clone? I am trying to render a 1.17 map while using an old config. The result looks like this: z0

A previous version (rendered with the OG Overviewer) of the old 1.16 map is properly biome colored: smallmap

The map is Drehmal: PRIMORDIAL & my rendered version of the old map is on map.drehmal.cyou.

Gregory-AM commented 1 year ago

Hey there, @Zottelchen! I'm downloading the map now, and double checking to see if there are any issues while rendering it.

Do you use a configuration file while rendering this map?

Zottelchen commented 1 year ago

Yeah, my configuration file is quite big as I wrote filters for a lot of stuff: https://map.drehmal.cyou/drehmal_render.conf

Make sure to download the Beta version 2.2: https://www.drehmal.net/apotheosisbeta / direct link@mega.nz.

Gregory-AM commented 1 year ago

I'm now downloading the Beta version, and I just downloaded the configuration. I'll have to get back to you on this issue after a render.

Thank you for sharing the configuration and which world.

Gregory-AM commented 1 year ago

I'm going to get back to this issue over the weekend. With how long the render is taking, I'm looking at a 8+ hour render time. I'm planning on making multiple renders with your configuration and modifying it to see if anything changes.

Gregory-AM commented 1 year ago

@Zottelchen, Do you know of the last version of Overviewer that worked with rendering the biome colors? Was it the last update that the original developers released, 1.19.10?

Zottelchen commented 1 year ago

Do you know of the last version of Overviewer that worked with rendering the biome colors? Was it the last update that the original developers released, 1.19.10?

@Gregory-AM Probably not, I released that rendered map back in November 2020.

Gregory-AM commented 1 year ago

@Zottelchen, I would recommend using the latest version of Overviewer that the original developers released on Overviewer.org, but keep the current version you're working with as a just in case it fails.

I tested it with the biome colors and it works, I'm not sure about the entities though as I'm sure the world has to be loaded at least once, and I'm having issues getting it to work for me.

I am going to see what went wrong when adding biome coloring for 1.20 and try to add backwards compatibility, but this will take time and I'm not sure how long it will take; as I'm planning on recloning Minecraft-Overviewer and slowly adding each change I've made to debug this issue since I know it's important to make sure Overviewer is compatible with every version of Minecraft.

Edit: I'm also going to try adding the entities also, which I attempted to do last night, but was having build and render errors when I attempted this in my world. So this too may take time.

JoshuaMarti commented 12 months ago

@Zottelchen, were you able to figure it out? I just checked your map page linked and it looks like things are properly colored.

Gregory-AM commented 12 months ago

@Zottelchen, were you able to figure it out? I just checked your map page linked and it looks like things are properly colored.

I think that's still the older version of his map. Sadly I haven't gotten around to this as I've been transitioning jobs, and doing things outside of development.

I tried pulling the Overviewer repo and comparing it to the successor and haven't been able to find what's causing this issue. I did this about a month ago.

Zottelchen commented 12 months ago

@JoshuaMarti @Gregory-AM It is actually the updated version of the map (e.g. look at the northern/snow part, the volcano looks different), but for the time being I've just used the old Overviewer (and for POIs I currently use basically a hardcoded variant of my config).