search

GreptimeTeam / greptimedb-operator

Run GreptimeDB on Kubernetes.
Apache License 2.0
37 stars 2 forks source link

fix: Cannot set default values in greptimedb cluster #173

Closed daviderli614 closed 2 months ago

daviderli614 commented 3 months ago

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The updates involve version upgrades for tools and dependencies, changes to type annotations for port variables, renaming fields in structs for clarity, and modifications to function signatures to enhance specificity. Additionally, enhancements to the Custom Resource Definition (CRD) structure and minor adjustments to build constraints are included. Overall, these changes aim to improve clarity, maintainability, and compatibility within the codebase.

Changes

File Path Change Summary
Makefile Updated KUSTOMIZE_VERSION to v5.3.0 and CONTROLLER_TOOLS_VERSION to v0.14.0.
apis/v1alpha1/defaulting.go Changed default port variables from untyped to int32. Replaced intstr.FromInt with intstr.FromInt32.
apis/v1alpha1/greptimedbstandalone_types.go Renamed HTTPServicePort to HTTPPort in GreptimeDBStandaloneSpec.
apis/v1alpha1/zz_generated.deepcopy.go Removed the build constraint // +build !ignore_autogenerated.
cmd/operator/app/command.go Replaced MetricsBindAddress with Metrics: metricsserver.Options{ BindAddress: o.MetricsAddr }.
config/crd/resources/greptime.io_greptimedbstandalones.yaml Updated CRD with new fields and annotations, changed controller-gen.kubebuilder.io/version to v0.14.0.
config/rbac/role.yaml Removed creationTimestamp from ClusterRole metadata.
controllers/greptimedbcluster/controller.go Refactored default value initialization in Reconcile function.
controllers/greptimedbcluster/deployers/common.go Changed UpdateStatus parameter type from client.UpdateOption to client.SubResourceUpdateOption.
controllers/greptimedbstandalone/controller.go Changed UpdateStatus parameter type from client.UpdateOption to client.SubResourceUpdateOption.
controllers/greptimedbstandalone/deployer.go Renamed HTTPServicePort to HTTPPort in several methods.
go.mod Updated various Go module dependencies to newer versions.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Controller
    participant CRD

    User->>Controller: Create or update resource
    Controller->>CRD: Validate and set defaults
    alt New Resource
        Controller->>CRD: Initialize default values
    end
    Controller->>CRD: Update status
    CRD-->>Controller: Acknowledge update
    Controller-->>User: Confirm resource status

🐇 "Oh, what a hop, what a skip,
Versions upgraded, let’s take a trip!
Ports now typed, clear as can be,
Renamed fields sing, 'Look at me!'
In the code, we dance and play,
Happy changes brighten the day!" 🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
zyy17 commented 2 months ago

@daviderli614 It's not a best practice to fix a bug and upgrade the dependencies simultaneously, which is not about the bug itself.

Can you please make the PR into two standalone PRs:

  1. Describe what the bug is and how to reproduce it. Reverting the code logic is not a good solution. After reviewing the code, I strongly suspect this is not a bug.

  2. Submit another PR to bump the dependencies;

daviderli614 commented 2 months ago

I will split this PR.