search

GreptimeTeam / greptimedb-operator

Run GreptimeDB on Kubernetes.
Apache License 2.0
37 stars 2 forks source link

feat: Add Azure Blob configuration to the object storage setting #221

Closed daviderli614 closed 3 days ago

daviderli614 commented 4 days ago

Released issue: https://github.com/GreptimeTeam/greptimedb-operator/issues/215

Summary by CodeRabbit

coderabbitai[bot] commented 4 days ago

Walkthrough

The changes introduce support for Azure Blob storage within the existing object storage framework. This includes the addition of a new AZBlobStorage struct and corresponding fields and methods in various files. The ObjectStorageProviderSpec is updated to include an AZBlob field, while the StorageConfig struct is enhanced to accommodate Azure Blob storage configuration parameters. Validation logic is also updated to ensure proper credential checks for the new storage type. Constants related to Azure account information are added, and deepcopy methods are implemented for the new struct.

Changes

File Path Change Summary
apis/v1alpha1/common.go Added AZBlob *AZBlobStorage to ObjectStorageProviderSpec, added GetAZBlobStorage() method, and defined AZBlobStorage struct with Container, SecretName, Root, and Endpoint fields. Added GetSecretName() and GetRoot() methods.
apis/v1alpha1/constants.go Added constants AccountName and AccountKey for Azure Blob storage configuration.
apis/v1alpha1/validate.go Introduced checkAZBlobCredentialsSecret for validating AZBlobStorage credentials in GreptimeDBCluster and GreptimeDBStandalone.
apis/v1alpha1/zz_generated.deepcopy.go Added deepcopy methods for AZBlobStorage and updated DeepCopyInto for ObjectStorageProviderSpec to handle the new AZBlob field.
pkg/dbconfig/common.go Enhanced StorageConfig by adding Container, AccountName, and AccountKey fields. Updated ConfigureObjectStorage to handle Azure Blob storage and introduced configureAZBlob method.

Poem

In the land where data flows,
A new storage type now grows.
Azure's Blob, a friend so dear,
With secrets kept, it draws us near.
Containers full, keys in hand,
A hopping change across the land! 🐇🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
zyy17 commented 3 days ago

@daviderli614 It's mostly LGTM. I think we should use azblob and AZBlob as part of the naming instead of using blob directly.

daviderli614 commented 3 days ago

@daviderli614 It's mostly LGTM. I think we should use azblob and AZBlob as part of the naming instead of using blob directly.

I changed it to use azblob to define this structure:

  objectStorage:
    azblob:
      container: "greptimedb"
      secretName: "azblob-credentials"
      endpoint: "https://<storage-account>.blob.core.windows.net"
      root: "cluster-with-blob-data"