Items can be taken from and given to Allays inside a claim without trust

snurre0 commented 2 years ago

Observed Behavior

Players without trust in another players claim, can take items from and give items to Allays inside the claim, and the Allay will follow them out of the claim.

Expected Behavior

Players without trust in a claim should not be able to take items from and give items to an Allay inside the claim.

Reproduction steps

Player A has an Allay inside their claim
Player A has given an item to the Allay
Player B does not have trust in Player A's claim
Player B can take the item from the Allay
Player B can also then give an item to the Allay, making the Allay follow them out of the claim

Stack trace or error log

No response

Server version

09.07 19:38:52 [Server] INFO Checking version, please wait...
09.07 19:38:52 [Server] INFO This server is running Paper version git-Paper-50 (MC: 1.19) (Implementing API version 1.19-R0.1-SNAPSHOT) (Git: c879064)
09.07 19:38:52 [Server] INFO You are 8 version(s) behind
09.07 19:38:52 [Server] INFO Download the new version at: https://papermc.io/downloads
09.07 19:38:52 [Server] INFO Previous version: git-Paper-378 (MC: 1.18.2)

GriefPrevention version

09.07 19:39:36 [Server] INFO GriefPrevention version 16.18-11-gb513e6a

Configuration

# Default values are perfect for most servers.  If you want to customize and have a question, look for the answer here first: http://dev.bukkit.org/bukkit-plugins/grief-prevention/pages/setup-and-configuration/

GriefPrevention:
  SeaLevelOverrides:
    Simplex: -1
    Simplex_nether: -1
    Simplex_the_end: -1
  Claims:
    Mode:
      Simplex: Survival
      Simplex_the_end: Survival
      Simplex_nether: Survival
    PreventGlobalMonsterEggs: true
    PreventTheft: true
    ProtectCreatures: true
    PreventButtonsSwitches: true
    LockWoodenDoors: true
    LockTrapDoors: true
    LockFenceGates: true
    EnderPearlsRequireAccessTrust: true
    RaidTriggersRequireBuildTrust: true
    ProtectHorses: true
    ProtectDonkeys: true
    ProtectLlamas: true
    InitialBlocks: 225
    Claim Blocks Accrued Per Hour:
      Default: 150
    Max Accrued Claim Blocks:
      Default: 300000
    Accrued Idle Threshold: 0
    AccruedIdlePercent: 0
    AbandonReturnRatio: 1.0
    AutomaticNewPlayerClaimsRadius: 4
    AutomaticNewPlayerClaimsRadiusMinimum: 0
    ExtendIntoGroundDistance: 20
    MinimumWidth: 1
    MinimumArea: 10
    MaximumDepth: -64
    InvestigationTool: STICK
    ModificationTool: GOLDEN_SHOVEL
    Expiration:
      ChestClaimDays: 9999999
      UnusedClaimDays: 9999999
      AllClaims:
        DaysInactive: 9999999
        ExceptWhenOwnerHasTotalClaimBlocks: 10000
        ExceptWhenOwnerHasBonusClaimBlocks: 5000
      AutomaticNatureRestoration:
        SurvivalWorlds: false
    AllowTrappedInAdminClaims: false
    MaximumNumberOfClaimsPerPlayer: 0
    CreationRequiresWorldGuardBuildPermission: true
    VillagerTradingRequiresPermission: true
    CommandsRequiringAccessTrust: /sethome;/esethome;/createhome;/ecreatehome
    DeliverManuals: true
    ManualDeliveryDelaySeconds: 30
    RavagersBreakBlocks: true
    FireSpreadsInClaims: false
    FireDamagesInClaims: false
    LecternReadingRequiresAccessTrust: true
  Spam:
    Enabled: true
    LoginCooldownSeconds: 60
    LoginLogoutNotificationsPerMinute: 5
    ChatSlashCommands: /me;/global;/local;/minecraft:me;/tpa;/suicide
    WhisperSlashCommands: ''
    WarningMessage: Please reduce your noise level.  Spammers will be muted.
    BanOffenders: false
    BanMessage: Banned for spam.
    AllowedIpAddresses: 1.2.3.4; 5.6.7.8
    DeathMessageCooldownSeconds: 60
    Logout Message Delay In Seconds: 0
  PvP:
    RulesEnabledInWorld:
      Simplex: true
      Simplex_nether: true
      Simplex_the_end: true
    ProtectFreshSpawns: true
    PunishLogout: false
    CombatTimeoutSeconds: 15
    AllowCombatItemDrop: true
    BlockedSlashCommands: /home;/vanish;/spawn;/tpa
    ProtectPlayersInLandClaims:
      PlayerOwnedClaims: false
      AdministrativeClaims: false
      AdministrativeSubdivisions: false
    AllowLavaDumpingNearOtherPlayers:
      PvPWorlds: false
      NonPvPWorlds: false
    AllowFlintAndSteelNearOtherPlayers:
      PvPWorlds: false
      NonPvPWorlds: false
    ProtectPetsOutsideLandClaims: true
  Economy:
    ClaimBlocksMaxBonus: 0
    ClaimBlocksPurchaseCost: 0.0
    ClaimBlocksSellValue: 0.0
  ProtectItemsDroppedOnDeath:
    PvPWorlds: true
    NonPvPWorlds: true
  BlockLandClaimExplosions: true
  BlockSurfaceCreeperExplosions: false
  BlockSurfaceOtherExplosions: false
  LimitSkyTrees: false
  LimitTreeGrowth: false
  PistonMovement: EVERYWHERE
  PistonExplosionSound: true
  FireSpreads: true
  FireDestroys: true
  AdminsGetWhispers: false
  AdminsGetSignNotifications: true
  VisualizationAntiCheatCompatMode: false
  SmartBan: true
  Mute New Players Using Banned Words: true
  MaxPlayersPerIpAddress: 5
  SilenceBans: true
  Siege:
    Worlds: []
    BreakableBlocks:
    - DIRT
    - GRASS
    - LONG_GRASS     <-- can't understand this entry, see BukkitDev documentation
    - COBBLESTONE
    - GRAVEL
    - SAND
    - GLASS
    - THIN_GLASS     <-- can't understand this entry, see BukkitDev documentation
    - WOOD     <-- can't understand this entry, see BukkitDev documentation
    - WOOL     <-- can't understand this entry, see BukkitDev documentation
    - SNOW
    DoorsOpenDelayInSeconds: 300
    CooldownEndInMinutes: 60
  EndermenMoveBlocks: true
  SilverfishBreakBlocks: true
  CreaturesTrampleCrops: true
  RabbitsEatCrops: true
  HardModeZombiesBreakDoors: true
  Database:
    URL: ''
    UserName: ''
    Password: ''
  UseBanCommand: false
  BanCommandPattern: ban %name% %reason%
  Advanced:
    fixNegativeClaimblockAmounts: true
    ClaimExpirationCheckRate: 60
    OfflinePlayer_cache_days: 90
  Abridged Logs:
    Days To Keep: 7
    Included Entry Types:
      Social Activity: true
      Suspicious Activity: false
      Administrative Activity: true
      Debug: false
      Muted Chat Messages: true
  ConfigVersion: 1

Plugin list

No response

Running without GriefPrevention

[ ] I attempted running the server without GriefPrevention installed.
[ ] The problem does not occur when GriefPrevention is removed from the server.

Running with only GriefPrevention

[ ] I attempted running only GriefPrevention on the server.
[ ] The issue still occurs when GriefPrevention is the only plugin running.

Running on a fresh, clean server installation

[ ] I attempted testing for the issue on a new server.
[ ] The issue still occurs on a new server.

Using unmodified client

[ ] I attempted testing for the issue with the vanilla client.
[ ] The issue still occurs when using the vanilla client.

We appreciate you taking the time to fill out a bug report!

[X] I searched for similar issues before submitting this bug report.

ryankayz7 commented 2 years ago

Can confirm. Am having this issue on my server too

L3v3lup commented 1 year ago

I can verify this, even exists on 16.18.1. Please fix that 👍

RoboMWM commented 1 year ago

Are allays considered passive animals? Cuz I don't think they're tamable?? (Idk haven't played much yet.) Always new entities mojang creates that need to be classified according to GP's rules...

RoboMWM commented 1 year ago

Oh, this has already been partially discussed at https://github.com/TechFortress/GriefPrevention/pull/1958#pullrequestreview-1220947807

Direct convo there please, thanks

GriefPrevention / GriefPrevention