Growlith1223 / ArsMagica2

Ars Magica 2 Bug Tracker
65 stars 31 forks source link

[1.10.2] 1.5.0-18 performance #324

Open WildKarrade opened 7 years ago

WildKarrade commented 7 years ago

I noticed that after starting up a server with some friends to play on that there was a decent amount of lag, more than there should be with 4 people. After investigating the timings with sponge I found that one of the culprits was AM2, taking up nearly 20% of the tick time for the eventmanager. And that's without any players on, it scales significantly when there are players on. Overall it seems like in 1.10.2 and beyond there needs to be some optimization work put in if possible.

Ars Magica 2::EventManager_onWorldTickcount(31656) total(10.89% 0.363s, 0.18% of tick)

WildKarrade commented 7 years ago

After further profiling the overall peformance of AM2, especially the event handler needs to be addressed. As an exmaple the am2.handler package is taking over 2,000ms to tick, not including other packages. Whereas ic2, mekanism, and immersive engineering, and even botania takes less than 100ms, or 20 times less.

TheIcyOne commented 7 years ago

Looks like a result of @Growlith1223's recent(relatively) changes in cc3e11e14983abfe00889892ce26cbf442d940e8. Does this occur only with AM2 tiles placed in world?

Growlith1223 commented 7 years ago

I am aware, I don't have access to Internet yet but once I do, I will be finishing up the networking, as it stands right now (tbh I never said it was perfect.) the system is a heavy wip. I am aware that the system is flawed, my best advice right now until I get inertnet, is to limit the amount of blocks you use.

The system adds EVERY tile entity to the list, and sending a very large packet, hence the issues. I forgot to split the packets after so many entities added lol.

On May 1, 2017 5:35 PM, "TheIcyOne" notifications@github.com wrote:

Looks like a result of @Growlith1223 https://github.com/Growlith1223's recent(relatively) changes in cc3e11e https://github.com/Growlith1223/ArsMagica2/commit/cc3e11e14983abfe00889892ce26cbf442d940e8. Does this occur only with AM2 tiles placed in world?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Growlith1223/ArsMagica2/issues/324#issuecomment-298450861, or mute the thread https://github.com/notifications/unsubscribe-auth/AFC9gYb79aQS91Iqet1sQs2_UaK0hbiDks5r1l4fgaJpZM4NLtH5 .

WildKarrade commented 7 years ago

Fair enough, just wanted to make sure you were aware of it is all.

LemADEC commented 7 years ago

With no blocks placed, and only one player online, I've noticed a large bandwidth usage: 15kB/s client->server, 50kB/s server-client. From what I've seen with warmroast, there's also a lot of GC going on too.

TheIcyOne commented 7 years ago

Looks like a direct result of the constant update calls.

Growlith1223 commented 7 years ago

i am aware of everything regarding the networking side, i just can't fix it till tomorrow.