GuGuss / ARTE-7-Downloader

User script to download videos from the ARTE+7 website
GNU General Public License v3.0
263 stars 33 forks source link

- Userscript encapsulation + clean jshint #11

Closed mimaison closed 9 years ago

mimaison commented 10 years ago
GuGuss commented 10 years ago

Hi, not sure what your change is about?

mimaison commented 10 years ago

Sorry I should have added more details as it looks like a big change. In fact it's not as big as it looks. I've done 3 things:

In the end, it's mostly style. I leave it up to you to decide if you want to merge it. There's nothing wrong with the script per se, I just want to improve it a bit.

ytrezq commented 10 years ago

@mimaison : Ok, but why did you encapsulated the code? This is is not necessary since the browser already does it when installing.

You also forgot to remove a dead function.

GuGuss commented 9 years ago

Thanks for the idea of improving Javascript. @ytrezq is right, no need for encapsulation here.

I removed the dead function and fixed some obvious JS issues!

Thanks guys.