Closed mimaison closed 9 years ago
Hi, not sure what your change is about?
Sorry I should have added more details as it looks like a big change. In fact it's not as big as it looks. I've done 3 things:
In the end, it's mostly style. I leave it up to you to decide if you want to merge it. There's nothing wrong with the script per se, I just want to improve it a bit.
@mimaison : Ok, but why did you encapsulated the code? This is is not necessary since the browser already does it when installing.
You also forgot to remove a dead function.
Thanks for the idea of improving Javascript. @ytrezq is right, no need for encapsulation here.
I removed the dead function and fixed some obvious JS issues!
Thanks guys.