search

GuckLab / impose

Align microscopy images using custom-defined structural patterns and superimpose those on data from other imaging modalities.
GNU General Public License v3.0
1 stars 0 forks source link

Upgrade to Qt6.2 #23

Closed raimund-schluessler closed 2 years ago

raimund-schluessler commented 2 years ago

This PR upgrades PyQt5 to PyQt6 in order to support Macs with M1 Arm processor, which are supported natively from Qt6.2 on.

codecov-commenter commented 2 years ago

Codecov Report

Merging #23 (90164c8) into main (fe839e6) will increase coverage by 0.01%. The diff coverage is 76.47%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   77.63%   77.64%   +0.01%     
==========================================
  Files          35       35              
  Lines        2423     2425       +2     
==========================================
+ Hits         1881     1883       +2     
  Misses        542      542
Impacted Files Coverage Δ
impose/__main__.py 0.00% <0.00%> (ø)
impose/gui/dlg_edit_shape.py 23.68% <50.00%> (ø)
impose/gui/main.py 65.97% <50.00%> (ø)
impose/gui/colocalize_pgrois.py 56.90% <75.00%> (ø)
impose/__init__.py 100.00% <100.00%> (ø)
impose/gui/collect.py 83.78% <100.00%> (ø)
impose/gui/collect_pgrois.py 82.81% <100.00%> (ø)
impose/gui/collect_shape_controls.py 62.37% <100.00%> (ø)
impose/gui/colocalize.py 56.66% <100.00%> (ø)
impose/gui/visualize.py 93.52% <100.00%> (ø)
... and 3 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

paulmueller commented 2 years ago

Could be related to pyqtgraph?

raimund-schluessler commented 2 years ago

Could be related to pyqtgraph?

Yes, indeed. It turns out that pyqtgraph failed to determine that it should use PyQt6 and was silently still using PyQt5 in the background. Forcing PyQt6 in 90164c8408b060b9ba761cb48ee269f47ebedd36 solved this problem.

raimund-schluessler commented 2 years ago

This should be good to be reviewed now. As far as I can tell, everything still works as it should.

raimund-schluessler commented 2 years ago

Thanks for the effort. Could you please update the changelog here as well (bump xyz from a to b)?

Done.