Guekka / bethutil

Common utilities for working with bethesda assets (dds, nif, bsa, hkx...)
https://guekka.github.io/bethutil/
Mozilla Public License 2.0
4 stars 1 forks source link

feat(modmanager): add attribute to ModFolder for skipping existing archives #55

Closed mklokocka closed 1 month ago

mklokocka commented 1 month ago

Add an optional attribute for the ModFolder class to skip processing existing archives.

In particular, the use case I have in mind is running CAO on the MO2 virtual file system, which can include at the very least base game archives, but also archives from mods etc.

A scenario in which this could be helpful is when the user wants to process and pack multiple mods together - not as single mods. Using MO2 VFS ensures proper conflict resolution between loose files. In those cases the user probably wouldn't want to touch the base game (or modded) BSAs.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.52%. Comparing base (de993e5) to head (4cea141).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Guekka/bethutil/pull/55/graphs/tree.svg?width=650&height=150&src=pr&token=llth93S2Em&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar)](https://app.codecov.io/gh/Guekka/bethutil/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) ```diff @@ Coverage Diff @@ ## dev #55 +/- ## ========================================== + Coverage 80.49% 80.52% +0.03% ========================================== Files 38 38 Lines 1712 1715 +3 ========================================== + Hits 1378 1381 +3 Misses 334 334 ``` | [Files](https://app.codecov.io/gh/Guekka/bethutil/pull/55?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) | Coverage Δ | | |---|---|---| | [include/btu/modmanager/mod\_folder.hpp](https://app.codecov.io/gh/Guekka/bethutil/pull/55?src=pr&el=tree&filepath=include%2Fbtu%2Fmodmanager%2Fmod_folder.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-aW5jbHVkZS9idHUvbW9kbWFuYWdlci9tb2RfZm9sZGVyLmhwcA==) | `0.00% <ø> (ø)` | | | [src/modmanager/mod\_folder.cpp](https://app.codecov.io/gh/Guekka/bethutil/pull/55?src=pr&el=tree&filepath=src%2Fmodmanager%2Fmod_folder.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar#diff-c3JjL21vZG1hbmFnZXIvbW9kX2ZvbGRlci5jcHA=) | `86.36% <100.00%> (+0.38%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/Guekka/bethutil/pull/55?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/Guekka/bethutil/pull/55?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Last update [de993e5...4cea141](https://app.codecov.io/gh/Guekka/bethutil/pull/55?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Edgar).
mklokocka commented 1 month ago

Hmm, I should probably move this over to dev branch (again).

Also comparing formatting from CI to the VS shipped clang-format and a standalone binary results I should start getting proper formatting with the standalone (hopefully).