GumbyFramework / Gumby

A Flexible, Responsive CSS Framework - Powered by Sass
http://gumbyframework.com/
2.85k stars 442 forks source link

Compass error when using 2:3 ratio #184

Closed ec8or closed 10 years ago

ec8or commented 10 years ago

I built a custom package leaving everything default except for the ratio which I set to Perfect fifth (2:3). When trying to compile the scss I receive the following error:

error sass/gumby.scss (Line 52 of sass/extensions/modular-scale/stylesheets/_modular-scale.scss: Undefined operation: "Infinity times 16px 78px".)

Tried using local gems instead and a number of other things (no ruby user normally though so not entirely sure what I was doing) but in the end I just changed the ratio to Golden and now everything works fine.

danhere commented 10 years ago

Make sure you are using the correct variables if you are going to change the ratio: https://github.com/Team-Sass/modular-scale#ratios

ec8or commented 10 years ago

I didn't change anything, just used the custom download builder here:

http://gumbyframework.com/customize

Will have a look and see if I can change it manually though, cheers.

danhere commented 10 years ago

If you still have the original download, would you mind pasting the line that sets the ratio? It's in var/_settings.scss on line 49.

https://github.com/GumbyFramework/Gumby/blob/master/sass/var/_settings.scss#L49

ec8or commented 10 years ago

Sure, here:

// Modular Scale Settings
// http://www.modularscale.com by Tim Brown
// https://github.com/scottkellum/modular-scale
$ratio: perfect-fifth();
$base-font-size: 16px !default;
$importantNum: 78px !default;
$base-size:  $base-font-size $importantNum;
ec8or commented 10 years ago

I changed it to $fifth() according to the link you pasted above and seems to work fine now :)

danhere commented 10 years ago

Awesome! Glad to hear it. Enjoy using Gumby. If you have any more questions check out our G+ community: https://plus.google.com/communities/108760896951473344451