GurliGebis / WoWAddon-AngrierWorldQuests

29 stars 14 forks source link

Not working with Better World Quests #12

Closed griddark closed 3 years ago

griddark commented 3 years ago

Describe the bug Map becoming buggy when installed with Better World Quests, icons showing in places they're not supposed to, and other addons (handynotes) also start showing icons where they shouldn't. Turning the addon off all the errors go away.

How to reproduce Run Better World Quests along side your addon.

What did you expect? Map pins to work.

Screenshots Map

**Bugsack** Click to expand! 31x ...rd_SharedMapDataProviders\WorldQuestDataProvider.lua:319: attempt to index local 'tagInfo' (a nil value) [string "@Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua"]:319: in function `AddWorldQuest' [string "@BetterWorldQuests\PinProvider.lua"]:107: in function `RefreshAllData' [string "@Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua"]:76: in function `OnMapChanged' [string "@Blizzard_MapCanvas\Blizzard_MapCanvas.lua"]:559: in function <...aceBlizzard_MapCanvas\Blizzard_MapCanvas.lua:557> [string "=[C]"]: ? [string "=[C]"]: in function `OnMapChanged' [string "@Blizzard_WorldMap\Blizzard_WorldMap.lua"]:234: in function `OnMapChanged' [string "@Blizzard_MapCanvas\Blizzard_MapCanvas.lua"]:59: in function `SetMapID' [string "@Blizzard_MapCanvas\Blizzard_MapCanvas.lua"]:757: in function `NavigateToParentMap' [string "@Blizzard_MapCanvas\MapCanvas_ScrollContainerMixin.lua"]:127: in function <...lizzard_MapCanvas\MapCanvas_ScrollContainerMixin.lua:102> [string "=[C]"]: ? Locals: self = { OnClearFocusedQuestID = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:79 EvaluateCheckBounties = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:63 OnEvent = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:166 OnMapInsetMouseLeave = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:46 AddWorldQuest = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:308 SetUsesSpellEffect = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:15 SetMatchWorldMapFilters = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:3 OnCanvasScaleChanged = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:50 registeredEvents =
{ } PingQuestID = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:153 owningMap = WorldMapFrame { } OnSetFocusedQuestID = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:75 activePins =
{ } OnHide = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:184 ShouldShowQuest = defined @AngrierWorldQuests\QuestFrame.lua:1033 IsUsingSpellEffect = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:23 OnCanvasSizeChanged = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:58 markActiveQuests = true checkBounties = true usesSpellEffect = true matchWorldMapFilters = true IsMarkingActiveQuests = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:98 OnRemoved = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:120 OnAdded = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:102 OnMapChanged = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:74 OnSuperTrackingChanged = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:255 GetMap = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:70 ClearFocusedQuestID = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:134 SignalEvent = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:97 GetPinTemplate = defined @BetterWorldQuests\PinProvider.lua:58 IsMatchingWorldMapFilters = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:11 OnShow = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:177 HandleMouseAction = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:103 spellEffectPin = { } suppressedQuests =
{ } OnMapInsetSizeChanged = defined @Blizzard_MapCanvas\MapCanvas_DataProviderBase.lua:38 IsCheckingBounties = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:59 IsQuestSuppressed = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:381 SetCheckBounties = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:50 ShouldOverrideShowQuest = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:196 GetBountyQuestID = defined @Blizzard_SharedMapDataProviders\WorldQuestDataProvider.lua:149 ticker =
{ } SetBountyQuestID = defined @Blizzard_SharedMapDataProviders\WorldQues
GurliGebis commented 3 years ago

Looking at the bugsack, it seems like the problem is in the code for the Better World Quests addon.

More specifically this line: BetterWorldQuests\PinProvider.lua"]:107: in function `RefreshAllData'

So it is not something I can change in here - please try and contact the people making the BetterWorldQuests addon, and see if they can see what i causing it on their end.

griddark commented 3 years ago

Thanks for taking the time GurliGebis to address this, the author of Better World Quests addon pointed out it was his addon and he had no intention of changing it, so I just had to find an alternative, as his addon interferes with any other world quest addon.