search

Gustash / react-native-giphy-keyboard

React Native implementation of the Giphy SDK for iOS and Android
12 stars 9 forks source link

iOS build broken #8

Closed brandonpearcy closed 4 years ago

brandonpearcy commented 4 years ago

React Native iOS build appears to be broken at head.

Steps to reproduce

Creating a fresh react-native project (v0.63.3), and confirm it works: $ npx react-native init MyApp $ cd MyApp $ yarn ios && yarn start

Now add giphy keyboard:

$ yarn add react-native-giphy-keyboard $ (cd ios; pod install) Open ios/MyApp.xcodeproj New file: Blank.swift Create Bridging Header $ yarn ios

Build error:

/Users/bpearcy/src/react-native-latest/MyApp/node_modules/react-native-giphy-keyboard/ios/EnumExtensions.swift:2:8: error: failed to load module 'GiphyUISDK' import GiphyUISDK

BUILD FAILED The following build commands failed: CompileSwift normal x86_64 /Users/bpearcy/src/react-native-latest/MyApp2/node_modules/react-native-giphy-keyboard/ios/EnumExtensions.swift CompileSwift normal x86_64 /Users/bpearcy/src/react-native-latest/MyApp2/node_modules/react-native-giphy-keyboard/ios/RNGiphyKeyboard.swift CompileSwiftSources normal x86_64 com.apple.xcode.tools.swift.compiler (3 failures)

filipef101 commented 4 years ago

check my pull request, with XCode 12.1 and my fork you should be able to build

Gustash commented 4 years ago

@filipef101's PR has been merged and released on npm as v2.0.0. Please update the package on your project to fix this issue. Closing.