search

Gusto / it-cpe-opensource

Tools used by the CPE team at Gusto to manage our endpoints and software deployment systems.
Other
59 stars 29 forks source link

Update cpe_activedirectory with bind/unbind functions / Enhance API structure #9

Closed erikng closed 4 years ago

erikng commented 4 years ago

Hm. I can do that but I kind of disagree. Are people realistically going to bind to a specific DC? That would be a lot of API work on their end to figure out the most appropriate domain controller (and another abstraction later). The best practice is for a vip to be created and let it route appropriately to something that's capable.

I can say with 99.99% certainty you nor anyone else deploying this through MDM does this. If you insist I do it, I can spend the cycles, but this is already more robust than pure MDM.

I think over complicating it needlessly just makes it more fragile.

erikng commented 4 years ago

Port checking vs ping is a reasonable request. I'll try and figure out the best route for that.

erikng commented 4 years ago

@w0de I've added port checking, but it requires an unmerged branch from our end to test: https://github.com/uber/cpe-chef-cookbooks/pull/34

erikng commented 4 years ago

Woot. Thanks for the review and enhancement ideas!

We'll merge the new uber_helpers next week once it lands internally.