Gwinel / likwid

Automatically exported from code.google.com/p/likwid
GNU General Public License v3.0
0 stars 0 forks source link

make likwid-accessD doesn't honor COMPILER #128

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. set COMPILER = MIC in config.mk
2. make
3. objdump -f likwid-accessD

What is the expected output? What do you see instead?

The file should be a MIC executable, built with ICC. Instead it's a host 
executable, built with GCC.

===>  Build access daemon likwid-accessD
make[1]: Entering directory `/root/pburka/likwid-3.1/src/access-daemon'
gcc -D_GNU_SOURCE -DMAX_NUM_THREADS=264 -I../includes -O2 -Wall -ansi -pedantic 
-Wextra -std=c99 -o ../../likwid-accessD accessDaemon.c

What version of the product are you using?

3.1.0

Please provide any additional information below.

It's not clear that likwid-accessD needs its own Makefile. I suggest just 
building it in the master Makefile along with the other executables.

Original issue reported on code.google.com by pe...@quux.net on 7 Feb 2014 at 9:12

GoogleCodeExporter commented 9 years ago
The reason that likwid-accessD is build standalone is to make things there as 
simple an isolated as possible to ease a security review on it. In computing 
centers there are concerns giving access to MSR registers and likwid-accessD 
(running setuid root) is a compromise between ease of use and security concerns.

Still I think this creates more problems than it solves. I will integrate the 
build more tightly.

Original comment by jan.trei...@gmail.com on 8 Feb 2014 at 1:14

GoogleCodeExporter commented 9 years ago
I integrated the accessD Makefile more tightly. Still for Phi there is now a 
check was added to prevent it is build. Still maybe accessD may be required on 
Phi in the future.

Original comment by jan.trei...@gmail.com on 12 Feb 2014 at 12:11

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 5aabab274cab.

Original comment by jan.trei...@gmail.com on 12 Feb 2014 at 3:16