Gwyrdain / apprentices-workshop

Creative Commons Zero v1.0 Universal
5 stars 2 forks source link

Import vs Import (parse only) is dropping some resets #127

Open TokugawaTFC opened 8 years ago

TokugawaTFC commented 8 years ago

I've sent you the area file so you can debug this. I imported the zone Te'nayu'ka into the editor. Cordir noticed two E resets were missing. The resets missing are below:

M 0 19872 1 19857 * a drow elf passenger -> The Passengers' Berth E 0 19869 100 15 * leather vambraces with spiderweb repousse E 0 19868 100 5 * an over-robe of emerald silkweave

Below are two screenshots: The parse (import only) shows the resets. The import review shows them missing.

import-only import-parse-only

Gwyrdain commented 8 years ago

It looks like those resets were "correctly" rejected.

Vambraces: Object of type "ARMS" being reset to the "RIGHT WRIST" position (15) -- should be ARMS (10) Over-robe: Object of type "ABOUT" being reset to the "BODY" position (5) -- should be ABOUT BODY (12)

Further thought is needed regard how best to deal with a situation like this.

  1. Reject with some form of error reporting? A reporting framework is not in place.
  2. Auto-fix and report what was done? Framework again.

Out of curiosity -- did these equips work in game?

TokugawaTFC commented 8 years ago

Yep, they worked. That's too bad about the import not displaying what it rejected. I don't think we can use the import if we do not know about items being rejected.

A drow elf passenger is using:

(Moderate magic) leather vambraces with spiderweb repousse (Moderate magic) an over-robe of emerald silkweave
Gwyrdain commented 8 years ago

I understand and agree. Not sure how to deal with it yet.