search

GyulyVGC / sniffnet

Comfortably monitor your Internet traffic 🕵️‍♂️
https://sniffnet.net
Apache License 2.0
14.41k stars 439 forks source link

Make it clearer that countries need to be entered as 2-letter ISO country code, not as string #555

Closed corneliusroemer closed 3 days ago

corneliusroemer commented 3 days ago

Is there an existing issue for this?

Describe the solution you'd like

Relabel the filter "Country" as "Country code" rather than "Country", as just country doesn't make it clear that one needs to enter 2-letter ISO codes. I typed China but couldn't find anything. Only much later did I discover I needed to type CN.

image

Feature #552 could help with this to some extent by showing the type of strings that are to be used for currently present data.

Is your feature request related to a problem?

No response

GyulyVGC commented 3 days ago

This is a good suggestion: older versions of the app showed countries in the table but now this is not anymore so evident.

As you pointed out, this can be solved by #552 and #354, so I don't think there's the need to also change the filter label, as it'd add some unneeded complexity.