search

HBehrens / puncover

Analyses C/C++ build output for code size, static variables, and stack usage
MIT License
431 stars 94 forks source link

Fix search for gcc_tools_base default value #84

Closed yperess closed 1 year ago

yperess commented 1 year ago

If find_arm_tools_location() fails and returns None, then os.path.join with throw and exception. Update to account for that scenario.

yperess commented 1 year ago

@HBehrens would you have any time this week to review this? I'm looking to use this as a part of our CI but it's breaking without this change.

XenuIsWatching commented 1 year ago

@HBehrens Will this be looked at soon. This is an issue that I also ran into

kartben commented 1 year ago

FWIW I can confirm that this fix worked for me.

noahp commented 1 year ago

Apologies, I'll be merging this today and releasing an update!

noahp commented 1 year ago

Fixed in 0bd63573b92b89aadf9aff716188ed15e364c0ca , thanks @yperess for the fix!