Code review at time fo WRR submissino - Githubissues

HEAL-KGS / STICr

A collection of functions for tidying and processing raw data from Stream Temperature, Intermittency, and Conductivity (STIC) loggers

GNU Affero General Public License v3.0

4 stars 2 forks source link

Code review at time fo WRR submissino #26

Closed samzipper closed 1 year ago

samzipper commented 1 year ago

A number of (mostly clarity) changes including:

adding necessary imports to functions
update DESCRIPTION and NAMESPACE with dependencies
formatting in documentation
adding in errors
standardizing variable names across functions
removing some defaults
switching to base pipe
fixing some bugs
updating test_threshold function - the previous version plot wasn't working
rename classified_stic_data.R to classified_df.R since this is what the actual data frame is named
delete unneeded hello.Rd file

Note: Double-check qaqc_stic_data.R, I had a merge conflict so make sure it is still working as intended