HEnquist / camilladsp

A flexible cross-platform IIR and FIR engine for crossovers, room correction etc.
https://henquist.github.io/
GNU General Public License v3.0
573 stars 49 forks source link

Target level cap - larger or equal config checks (v3) #373

Open siraaris opened 3 weeks ago

siraaris commented 3 weeks ago

Checks for target_level in config and UI note that:

target_level can't be larger than X (when target_level is set to X).

Screenshot 2024-11-06 at 6 04 08 am

A similar note is given in src/config.rs:

if conf.devices.target_level() >= target_level_limit {
    let msg = format!("target_level can't be larger than {}", target_level_limit);
    return Err(ConfigError::new(&msg).into());

Maybe the check should be > or the message updated to say larger or equal to...

HEnquist commented 3 weeks ago

Thanks! Fixed in the next30 branches of camilladsp and pycamilladsp-plot.