[TTAHUB-3326] Fix some mailer bugs

HHS / Head-Start-TTADP

OHS TTA Hub data system. ACF SO, Dana Jones-Quartey. Tech lead: Krys Wisnaskas

Main: https://ttahub.ohs.acf.hhs.gov/

21 stars 7 forks source link

[TTAHUB-3326] Fix some mailer bugs #2460

Closed thewatermethod closed 2 weeks ago

thewatermethod commented 3 weeks ago

Description of change

Digests were not correctly logging "onCompleteNotification"
An invalid constant was used for one of the jobs
TR notifications had start date and end date backwards

How to test

Confirm that digests send without error (this is onerous to set up locally, I apologize)
Confirm that the correct constant was used the recipient report approved digest job
Confirm that POC notifications will send for the TR report "missingSessionInfo" job

Issue(s)

https://jira.acf.gov/browse/TTAHUB-3326

Checklists

Every PR

[ ] Meets issue criteria
[ ] JIRA ticket status updated
[ ] Code is meaningfully tested
[ ] Meets accessibility standards (WCAG 2.1 Levels A, AA)
[ ] API Documentation updated
[ ] Boundary diagram updated
[ ] Logical Data Model updated
[ ] Architectural Decision Records written for major infrastructure decisions
[ ] UI review complete

Before merge to main

[ ] OHS demo complete
[ ] Ready to create production PR

Production Deploy

[ ] Staging smoke test completed

After merge/deploy

[ ] Update JIRA ticket status

thewatermethod commented 3 weeks ago

Found by @kryswisnaskas during her review, although unrelated will try to address here

kryswisnaskas commented 3 weeks ago

I am still seeing an error if there is a failed notification (in onFailedNotification)

Following is the job.data that is being sent to the logger for the reportApprovedDigest (the name is obfuscated)

{
  user: {
    fullName: 'Joe Smith',
    nameWithNationalCenters: 'Joe Smith, ',
    id: 907,
    homeRegionId: 6,
    hsesUserId: '56181',
    hsesUsername: 'Joe Smith@redacted.com',
    hsesAuthorities: [ 'ROLE_FEDERAL' ],
    name: 'Joe Smith',
    phoneNumber: null,
    email: 'Joe Smith@redacted.com',
    flags: [],
    lastLogin: '2024-10-27T10:46:13.505Z',
    createdAt: '2024-09-13T16:43:51.904Z',
    updatedAt: '2024-10-27T10:46:13.505Z',
    validationStatus: [ [Object] ]
  },
  reports: [],
  type: 'reportApprovedDigest',
  freq: 'today',
  subjectFreq: 'daily'
}
line 100
2024-11-08T16:23:10.408Z AUDIT error:   Queue encountered an error: Cannot read properties of undefined (reading 'displayId') {}

kryswisnaskas commented 3 weeks ago

I verified that the digest notification logging is still outstanding. We have that covered in TTAHUB-2099 though.

thewatermethod commented 2 weeks ago

@kryswisnaskas I believe I've addressed your feedback