HK3-Lab-Team / pytrousse

PyTrousse collects into one toolbox a set of data wrangling procedures tailored for composing reproducible analytics pipelines.
Apache License 2.0
0 stars 1 forks source link

logging.error should instead raise error usually #32

Open lorenz-gorini opened 4 years ago

lorenz-gorini commented 4 years ago

Like in feature_fix.encode_single_categorical_column, the logging.error should actually raise a specific Error since no error handling is implemented and no further operations are performed when the function stops.

Similar behaviors should be fixed in convert_features_from_bool_to_binary, encode_multi_categorical_columns in feature_fix.py module or statistical_tests.subgroups_statistical_test and in DataFrameWithInfo methods.