search

HLinChen / VCR-GauS

[NeurIPS 2024] VCR-GauS: View Consistent Depth-Normal Regularizer for Gaussian Surface Reconstruction
https://hlinchen.github.io/projects/VCR-GauS/
Other
89 stars 1 forks source link

local variable 'trans' referenced before assignment #1

Closed scy5335 closed 1 week ago

scy5335 commented 1 week ago

Line 239 In dataset_readers.py, the trans isn't defined before using it. How can I fixed this bug? image

HLinChen commented 1 week ago

Do you train on custom data?

scy5335 commented 1 week ago

No. I train on mip-nerf360 datasets.

HLinChen commented 1 week ago

I have just pushed an update. Please run git pull to get the latest version.

scy5335 commented 1 week ago

I have just pushed an update. Please run git pull to get the latest version.

If "meta_fname" is not existed, the parameter "trans" of "filter_point_cloud" will be still undefined?

HLinChen commented 1 week ago

It will be generated in line 252.

scy5335 commented 1 week ago

this code is both in line 239 and line 283, the origin mip-nerf360 dataset don't have meta.json and points3D.ply. In line 239, the code will cause error. image image

HLinChen commented 1 week ago

Fixed. Just comment this line.