HOZHENWAI / Beets-Plugin_VGMdb

A small plugin to collect metadata from VGMdb and manage a VGMdb collection

13 stars 2 forks source link

investigate network issues #20

Open HOZHENWAI opened 1 year ago

HOZHENWAI commented 1 year ago

there are reported network issues that appear when inputing a manual album id... It seems those network errors disappear after the first call.

Check for:

async issues
broken messages
json decode error

ivan-boikov commented 8 months ago

I think I have a related issue.

Looks like during an import of an album (before an ID is manually provided), VGMplug sends many requests to the server and gets rate-limited. Before that happens, I get a few VGMplug: Network Problem ____ around multiple VGMplug: Final artist choice ____, so maybe the inference of artists is costly? After VGMplug gives up, I still get network problems when passing an ID, but after a minute it works, so I bet on rate limiting.

EDIT: likely related https://github.com/hufman/vgmdb/issues/81

HOZHENWAI commented 8 months ago

26 we will see if this fixes this then

ivan-boikov commented 8 months ago

@HOZHENWAI You can already make automatic import optional with the --search-id flag which applies for Musicbrainz and VGMdb at the same time.

I had a few entries who errored even after a few minutes. I checked then through vgm.info directly and I also got a 503. A few minutes ago vgm.info did not work at all. So I guess the plugin is not at fault.

EDIT: damn, you are quick!

HOZHENWAI commented 8 months ago

more options does not hurt, thank you for investigating though