HOZHENWAI / Beets-Plugin_VGMdb

A small plugin to collect metadata from VGMdb and manage a VGMdb collection
13 stars 2 forks source link

problems with multi-disc tagging #3

Closed u2716 closed 2 years ago

u2716 commented 2 years ago

why second (third/....) disc's tracks don't start with 01 02 ...? for example, if an album has first disc with 20 tracks and second disc with 30 tracks, the first disc is tagged correctly as D1 01 02 03 ... , but the second one is tagged as D2 21 22 23 24 .... , while it should be tagged as D2 01 02 03 04 ....

Another problem I have with multi-disc albums is that tracks get riorganized wrongly. that happens always, that's why I usually retag them manually. example: https://vgmdb.info/album/121600

Correcting tags from:
    高田龍一 - TVアニメ「サマータイムレンダ」オリジナル サウンドトラック [Disc 1]
To:
    Keiichi Okabe - TV Animation "Summer Time Rendering" Original Soundtrack
URL:
    https://vgmdb.net/album/121600?perpage=99999
(Similarity: 59.0%) (tracks, album) (VGMdb, 2x2 CD, 2022, MAGES., USSW-0379)
2 CD 0: Disc 1 [USSW-0379-1]
 * 霧這 (#15)         -> Uzu (#1) (title, index)
 * 潮騒               -> Shiosai (title)
 * 陽炎               -> Kagerou (title)
 * 月灯               -> Kyoumei (title)
 * 張力               -> Choryuoku (title)
 * 影法師              -> Kageboushi (title)
 * 修羅火 (#10)        -> Inryoku (#7) (title, index)
 * 反射               -> Hansya (title)
 * 沈力               -> Chinryoku (title)
 * 心騒ぎ              -> Munasawagi (title)
 * 共鳴 (#4) (2:02)   -> Yodomi (#11) (1:50) (title, index, length)
 * 深夏               -> Shinka (title)
 * 脳溝               -> Noukou (title)
 * 臨影               -> Rinei (title)
 * 浮力               -> Furyoku (title)
 * 洞                -> Dou (title)
 * 波の綾              -> Naminoaya (title)
 * 異形乃輪             -> Igyounorin (title)
 * 凪                -> Nagi (title)
 * 漣                -> Sazanami (title)
 * 狂濤               -> Kyoutou (title)
 * 砕波               -> Saiha (title)
 * 澱 (#11)          -> Dekihaku (#23) (title, index)
 * 対峙               -> Taiji (title)
 * 迷ひ路              -> Mayoiji (title)
 * 絶つ望              -> Zetsubou (title)
 * 葛藤               -> Kattou (title)
 * 軋轢               -> Atsureki (title)
 * 島風 (#28) (2:29)  -> Wakusen (#29) (2:41) (title, length)
 * 遁走               -> Tonsou (title)
2 CD 1: Disc 2 [USSW-0379-2]
 * 日都ケ島手毬唄 (#8)     -> Denshidei (#31) (title, index)
 * 渦 (#1)           -> Monoanji (#32) (title)
 * 溺迫 (#23)         -> Kishou (#33) (title, index)
 * 危礁 (#3) (1:51)   -> Gettou (#34) (2:07) (title, length)
 * 傀儡争 (#5)         -> Kugutsusou (#35) (title, index)
 * 影息吹 (#6)         -> Kageibuki (#36) (title, index)
 * 湿力 (#9) (2:48)   -> Shide (#37) (3:03) (title, index, length)
 * 電子泥 (#1)         -> Hitogashimatemariuta (#38) (title, index)
 * 垂 (#7) (3:03)    -> Shitsuryoku (#39) (2:48) (title, index, length)
 * 生謡 (#14)         -> Shuraka (#40) (title, index)
 * 白い青 (#11)        -> Shiroiao (#41) (title, index)
 * 呟奇譚 (#12)        -> Tsubukitan (#42) (title, index)
 * 鎮魂 (#13)         -> Chinkon (#43) (title, index)
 * 引力 (#7)          -> Ikiutai (#44) (title, index)
 * 墨斗兵 (#18)        -> Mubai (#45) (title, index)
 * 鯨閃 (#16)         -> Geisen (#46) (title, index)
 * 和心地 (#22) (2:05) -> Haine (#47) (2:17) (title, index, length)
 * 波稲 (#17) (2:17)  -> Bokutohei (#48) (2:06) (title, length)
 * 物案じ (#2)         -> Kunpu (#49) (title, index)
 * 薫風 (#19)         -> Senshi (#50) (title)
 * 潜思 (#20)         -> Kioku (#51) (title)
 * 記憶 (#21) (1:52)  -> Nagokoshi (#52) (2:05) (title, length)
 * 翻命 (#27)         -> Onmyou (#53) (title, index)
 * 疾波闘 (#24)        -> Shippatou (#54) (title, index)
 * 破綻 (#25)         -> Hatan (#55) (title, index)
 * 再輝動 (#26)        -> Saikidou (#56) (title, index)
 * 輪廻 (#29)         -> Honmei (#57) (title, index)
 * 惑戦 (#29) (2:41)  -> Shimakaze (#58) (2:29) (title, index, length)
 * 陰陽 (#23) (2:40)  -> Rinne (#59) (2:30) (title, index, length)
HOZHENWAI commented 2 years ago

@Victorbry99 For the first answer to your question, I think it's due to how beets manage multi disck albums https://beets.readthedocs.io/en/v1.3.1/faq.html#import-a-multi-disc-album. To solve this problem you will need to change the config by setting per_disc_numbering to true as written in the official documentation https://beets.readthedocs.io/en/latest/reference/config.html#per-disc-numbering. I'll investigate for the second issue but i think it's a distance issue.

HOZHENWAI commented 2 years ago

Can you send me a track for debugging?

HOZHENWAI commented 2 years ago

Nvm, I found the issue, will bugfix that. You don't need to send me tracks

HOZHENWAI commented 2 years ago

It should be fixed on main. You can update your version and test.