Coin Limit - Githubissues

HOdlcoin / HOdlcoin

HODL!

http://hodlcoin.com

MIT License

37 stars 21 forks source link

Coin Limit #144

Open amit177 opened 1 year ago

amit177 commented 1 year ago

The coin inflation caused the following issues:

Wallets with more than the MAX_MONEY value fail when opening due to "out of range" error (community reported, untested).
The number of coins that can be sent on a single transaction is also limited to the same MAX_MONEY value - which is pretty small compared to what wallets have now

https://github.com/HOdlcoin/HOdlcoin/blob/af3b020d2f6250d4ee2592bb6f3289e498c84550/src/amount.h#L20

It appears this change will require a hard-fork:

https://github.com/HOdlcoin/HOdlcoin/blob/af3b020d2f6250d4ee2592bb6f3289e498c84550/src/main.cpp#L871-L873

A hard-fork might kill the coin completely since few people will update to that version. We need to decide what would be better.

amit177 commented 1 year ago

Opened for community discussion

ck-kc commented 1 year ago

I think hard fork should be done if it seems to be needed for the change to be successful. At this point people have nothing to lose as the coin will die anyway.

Requiring node operators to upgrade may make people focus some (brief) attention on the coin.

I'm happy to run a node for a while.

If a hard fork is to be done, it may be worth considering what other changes would be prudent to be made at the same time.

Do people want to reduce interest rates again? Or will that unfairly advantage in favour of some huge whales?

Would be good to get a block explorer up and running again to see how many whales there are, how big they are and the distribution of coins to these wallets.

geoant128 commented 1 year ago

My transactions exceeded 600 millions after maturation so (value out of range). Do you think there will be actually a hard fork?If yes just loading the wallet.dat will be ok for the wallet to be functional again?

(If a hard fork is to be done, it may be worth considering what other changes would be prudent to be made at the same time.) Totally agree!! Capture Capture1

amit177 commented 1 year ago

It should be possible to split the MoneyRange check and allow the client to start properly without breaking the chain. @FreeTrade what do you think?

FreeTrade commented 1 year ago

Sounds possible. Might be better to just do the fork though.