search

HPInc / jipp

A Java-compatible implementation of IPP
MIT License
153 stars 42 forks source link

IppPacket builders #81

Closed GladeDiviney closed 4 years ago

GladeDiviney commented 4 years ago

Fix #77 with the implementation of IppPacket builders. These builders enforce the presence of all MUST attributes.

Must the requesting-user-name appear before other attributes for some printer models?

codecov-io commented 4 years ago

Codecov Report

Merging #81 into next will increase coverage by 0.41%. The diff coverage is 96.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##               next      #81      +/-   ##
============================================
+ Coverage     86.01%   86.43%   +0.41%     
- Complexity      443      455      +12     
============================================
  Files            67       67              
  Lines          1552     1644      +92     
  Branches        238      241       +3     
============================================
+ Hits           1335     1421      +86     
- Misses           83       88       +5     
- Partials        134      135       +1
Impacted Files Coverage Δ Complexity Δ
jipp-core/src/main/java/com/hp/jipp/dsl/dsl.kt 59.37% <0.00%> (-37.50%) 0.00 <0.00> (ø)
...c/main/java/com/hp/jipp/encoding/AttributeGroup.kt 66.66% <0.00%> (-4.77%) 0.00 <0.00> (ø)
...re/src/main/java/com/hp/jipp/encoding/IppPacket.kt 96.66% <97.67%> (+23.13%) 28.00 <0.00> (+5.00)
...java/com/hp/jipp/encoding/MutableAttributeGroup.kt 97.67% <100.00%> (+8.20%) 40.00 <18.00> (+8.00)
...ain/java/com/hp/jipp/encoding/IntOrIntRangeType.kt 84.61% <0.00%> (-7.70%) 9.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57c8217...775f6f4. Read the comment docs.